style(knapsack): adjusting style overrides for new update #2390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes changes to the
apps/knapsack/public/ks-overrides.css
file to improve the layout and responsiveness of the application. The most important changes include adding HTML to the body selector for background color consistency and introducing new CSS rules to ensure certain elements have appropriate minimum width and height based on their parent elements.What's included?
html
to thebody
selector to ensure the background color is applied consistently across the entire page.knapsack-wrapper
andknapsack-pattern-direct-parent
to ensure they have a minimum width and height of 100vw and 100vh respectively when they contain specific child elements likecv-action-ribbon
,cv-top-app-bar
, orcv-toolbar
.knapsack-wrapper
elements to ensure a minimum width of 100vw when they contain child elements such ascv-alert
,cv-linear-progress
,cv-slider
, orcv-slider-range
.Test Steps
nx run knapsack:serve
General Tests for Every PR
npm run start
still works.npm run lint
passes.npm run stylelint
passes.npm test
passes and code coverage is not lower.npm run build
still works.Screenshots or link to StackBlitz/Plunker