Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(knapsack): adjusting style overrides for new update #2390

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

owilliams320
Copy link
Collaborator

Description

This pull request includes changes to the apps/knapsack/public/ks-overrides.css file to improve the layout and responsiveness of the application. The most important changes include adding HTML to the body selector for background color consistency and introducing new CSS rules to ensure certain elements have appropriate minimum width and height based on their parent elements.

What's included?

  • Added html to the body selector to ensure the background color is applied consistently across the entire page.
  • Introduced a new CSS rule for elements with the class knapsack-wrapper and knapsack-pattern-direct-parent to ensure they have a minimum width and height of 100vw and 100vh respectively when they contain specific child elements like cv-action-ribbon, cv-top-app-bar, or cv-toolbar.
  • Added another CSS rule for knapsack-wrapper elements to ensure a minimum width of 100vw when they contain child elements such as cv-alert, cv-linear-progress, cv-slider, or cv-slider-range.

Test Steps

  • nx run knapsack:serve
  • then open knapsack locally and test the action ribbon component

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to StackBlitz/Plunker

Screenshot 2025-02-05 at 7 17 33 PM

@owilliams320 owilliams320 temporarily deployed to covalent-pip-fix-knapsa-5z7bvm February 6, 2025 14:50 Inactive
@adamnel adamnel merged commit 194ec12 into main Feb 6, 2025
6 checks passed
@adamnel adamnel deleted the fix/knapsack-style-overrides branch February 6, 2025 14:55
@owilliams320
Copy link
Collaborator Author

🎉 This PR is included in version 10.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants