Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(icon-demo): add an icon demo to display all icons #2303

Merged
merged 6 commits into from
Jan 14, 2025
Merged

Conversation

bsahitya
Copy link
Collaborator

Description

Add an icon-demo web component in covalent/components. To display all icons in a demo in knapsack we need to either create an angular or web component and add it to a custom demo in knapsack.

What's included?

  • Add icon-demo component in components
  • Add a custom demo for all icons in icon docs of knapsack
  • Use the newly created component in custom demo
  • Integrate the icon-demo into the icon overview page in knapsack

Test Steps

  • npm run storybook
  • then go to Icon/All icons story
  • nx run knapsack:start
  • Open Icon docs and view the overview page

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to StackBlitz/Plunker
Screenshot 2024-12-26 at 4 12 30 PM Screenshot 2024-12-26 at 4 12 48 PM Screenshot 2024-12-26 at 4 12 59 PM

@owilliams320 owilliams320 temporarily deployed to covalent-pip-docs-icon--cyzg4g December 26, 2024 22:18 Inactive
@adamnel
Copy link
Collaborator

adamnel commented Dec 30, 2024

Can we create filtered versions of this? For example, I'd like to be able to embed a listing of the state_* icons on the relevant page for reference in the docs.

@owilliams320 owilliams320 had a problem deploying to covalent-pip-docs-icon--cyzg4g January 9, 2025 20:59 Failure
@owilliams320 owilliams320 temporarily deployed to covalent-pip-docs-icon--cyzg4g January 9, 2025 21:05 Inactive
@owilliams320 owilliams320 had a problem deploying to covalent-pip-docs-icon--cyzg4g January 14, 2025 16:17 Failure
@owilliams320 owilliams320 temporarily deployed to covalent-pip-docs-icon--cyzg4g January 14, 2025 20:37 Inactive
@owilliams320 owilliams320 temporarily deployed to covalent-pip-docs-icon--cyzg4g January 14, 2025 20:44 Inactive
@adamnel adamnel merged commit 9e02acc into main Jan 14, 2025
7 checks passed
@adamnel adamnel deleted the docs/icon-demo branch January 14, 2025 21:12
@owilliams320
Copy link
Collaborator

🎉 This PR is included in version 9.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants