refactor(review): changes from code review

Teradata · Feb 8, 2024 · b6f7241 · b6f7241
1 parent 2184f6d
commit b6f7241
Show file tree

Hide file tree

Showing 10 changed files with 1,324 additions and 45,643 deletions.
diff --git a/.storybook/theme/covalent.dark.theme.js b/.storybook/theme/covalent.dark.theme.js
@@ -8,7 +8,7 @@ import {
   CvDarkOnBackground,
   CvLightOnBackground,
   CvDarkTextIconOnBackground,
-} from '../../libs/tokens/_generated/index';
+} from '@covalent/tokens';
 
 export default create({
   base: 'dark',

diff --git a/.storybook/theme/covalent.light.theme.js b/.storybook/theme/covalent.light.theme.js
@@ -8,7 +8,7 @@ import {
   CvDarkOnBackground,
   CvLightOnBackground,
   CvLightTextIconOnBackground,
-} from '../../libs/tokens/_generated/index';
+} from '@covalent/tokens';
 
 export default create({
   base: 'light',

diff --git a/libs/components/.storybook/manager-head.html b/libs/components/.storybook/manager-head.html
@@ -11,6 +11,13 @@
     box-shadow: none;
   }
 
+  .light #root > div > div[role='main'] > div {
+    border: 1px solid rgba(0, 0, 0, 0.12);
+  }
+  .dark #root > div > div[role='main'] > div {
+    border: 1px solid rgba(255, 255, 255, 0.12);
+  }
+
   .light #storybook-explorer-tree .sidebar-item[data-selected='true'],
   .light #storybook-explorer-tree .sidebar-item[data-selected='true'] svg {
     color: var(--cv-light-on-primary);

diff --git a/libs/components/src/app-shell/app-shell.ts b/libs/components/src/app-shell/app-shell.ts
@@ -83,6 +83,9 @@ export class CovalentAppShell extends DrawerBase {
   }
 
   private _handleMenuClick() {
+    this.mdcRoot.dispatchEvent(
+      new Event('transitionend', { bubbles: true, composed: true })
+    );
     // Forcefully toggle the open/close state
     this._toggleOpen(!this.forcedOpen);
 
@@ -152,7 +155,7 @@ export class CovalentAppShell extends DrawerBase {
     const modal = this.type === 'modal';
     const classes = {
       'cov-drawer--forced-open': this.forcedOpen,
-      'cov-drawer--open': this.drawerOpen,
+      'cov-drawer--open': this.drawerOpen || this.forcedOpen,
       'cov-drawer--hovered': this.hovered,
     };
     const drawerClasses = {

diff --git a/libs/tokens/_generated/_index.scss b/libs/tokens/_generated/_index.scss
diff --git a/libs/tokens/_generated/index.css b/libs/tokens/_generated/index.css
diff --git a/libs/tokens/_generated/index.d.ts b/libs/tokens/_generated/index.d.ts
diff --git a/libs/tokens/_generated/index.js b/libs/tokens/_generated/index.js