build: 修复IDE无法直接Run项目的问题 #1362
Merged
build: 修复IDE无法直接Run项目的问题 #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
经过反复分析现有代码，无法在不改动SDK层代码的前提下修复这个问题。 主要是因为Shadow的Gradle plugin有硬编码outputs目录的情况。 并且这个Plugin还假设了Gradle配置阶段就能确定apk的最终路径， 这与现状不符。目前是配置完成后，IDE还能决定将apk的输出路径改到intermediates中。 所以很难简单的修复这个假设的错误。 考虑到主要要解决的问题还是Shdaow自身项目希望能在IDE中直接run起来。 决定还是将intermediates中的apk直接复制到原本的路径。这样其他代码都不用改动。 fix Tencent#1263
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
经过反复分析现有代码，无法在不改动SDK层代码的前提下修复这个问题。
主要是因为Shadow的Gradle plugin有硬编码outputs目录的情况。
并且这个Plugin还假设了Gradle配置阶段就能确定apk的最终路径，
这与现状不符。目前是配置完成后，IDE还能决定将apk的输出路径改到intermediates中。
所以很难简单的修复这个假设的错误。
考虑到主要要解决的问题还是Shdaow自身项目希望能在IDE中直接run起来。
决定还是将intermediates中的apk直接复制到原本的路径。这样其他代码都不用改动。
fix #1263