Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): add a null protection to animator #3764

Merged
merged 1 commit into from
Feb 28, 2024
Merged

fix(ios): add a null protection to animator #3764

merged 1 commit into from
Feb 28, 2024

Conversation

wwwcg
Copy link
Collaborator

@wwwcg wwwcg commented Feb 28, 2024

Pre-PR Checklist

  • I added/updated relevant documentation.
  • I followed the Convention Commit guideline with maximum 72 characters to submit commit message.
  • I squashed the repeated code commits.
  • I signed the [CLA].
  • I added/updated test cases to check the change I am making.
  • All existing and new tests are passing.

@wwwcg wwwcg requested a review from ruifanyuan as a code owner February 28, 2024 11:47
@wwwcg wwwcg changed the title fix(ios): add a null protection to animator fix(ios): add a null protection to animator #3725 Feb 28, 2024
@github-actions github-actions bot added the size: xs Denotes a PR that changes 0-9 lines label Feb 28, 2024
@hippy-service Hippy Service
Copy link

hippy-service bot commented Feb 28, 2024

Hi, @wwwcg. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@wwwcg wwwcg changed the title fix(ios): add a null protection to animator #3725 fix(ios): add a null protection to animator Feb 28, 2024
@wwwcg
Copy link
Collaborator Author

wwwcg commented Feb 28, 2024

ref #3725

@wwwcg wwwcg linked an issue Feb 28, 2024 that may be closed by this pull request
iOS Hippy 2.17.2 HPOPAnimator Crash #3725
Closed
@hippy-service Hippy Service
Copy link

hippy-service bot commented Feb 28, 2024

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Feb 28, 2024
@hippy-actions hippy-actions bot enabled auto-merge (rebase) February 28, 2024 11:55
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Feb 28, 2024
@hippy-actions hippy-actions bot merged commit 48fd18b into Tencent:master Feb 28, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruifanyuan ruifanyuan ruifanyuan approved these changes

Assignees
No one assigned
Labels
framework: ios size: xs Denotes a PR that changes 0-9 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iOS Hippy 2.17.2 HPOPAnimator Crash
2 participants
@wwwcg @ruifanyuan