Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(android): support output render log to host #3733

Merged
merged 2 commits into from
Jan 22, 2024
Merged

feat(android): support output render log to host #3733

merged 2 commits into from
Jan 22, 2024

Conversation

siguangli
Copy link
Collaborator

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@siguangli siguangli requested a review from iPel as a code owner January 22, 2024 13:00
@hippy-service Hippy Service
Copy link

hippy-service bot commented Jan 22, 2024

Hi, @siguangli. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

iPel
iPel approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@iPel iPel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hippy-service hippy-service bot added the action(rebase-merge) Rebase and merge action (maybe privileged) label Jan 22, 2024
@hippy-service Hippy Service
Copy link

hippy-service bot commented Jan 22, 2024

🎉 It seems that this pull request has been approved by all required reviewers. As it only contains one normal commit, I will rebase and merge it automatically via add action(rebase-merge) label.

@hippy-actions hippy-actions bot enabled auto-merge (rebase) January 22, 2024 13:08
@hippy-actions hippy-actions bot removed the action(rebase-merge) Rebase and merge action (maybe privileged) label Jan 22, 2024
@hippy-actions hippy-actions bot merged commit 8c13d04 into Tencent:main Jan 22, 2024
19 checks passed
@siguangli siguangli deleted the feat/HippyLogAdapter branch January 22, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iPel iPel iPel approved these changes

Assignees
No one assigned
Labels
framework: android module: android renderer: native size: m Denotes a PR that changes 100-499 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@siguangli @iPel @siguangli2018 @open-hippy