Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing library: NVActivityIndicatorView #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mustafagunes
Copy link

@mustafagunes mustafagunes commented Feb 13, 2024

Problem

When I install Desk360 into my project with SPM, the compiler gives an error because the library (NVActivityIndicatorView) cannot be found. This pr aims to fix the problem by adding the NVActivityIndicatorView library to SPM.

Impact

Package.swift

Solution 🛠

This pr fixes the problem by adding the NVActivityIndicatorView library to Package.swift.

How to test the changes locally 🧐

Add a simple new application project, try adding it with SPM and build it.

Checklist ✅

  • The code architecture and patterns are consistent with the rest of the codebase.
  • The changes have been tested and following the documented guidelines
  • The CHANGELOG.md has been updated to reflect the changes. In case of a breaking change, it's been flagged as such.
  • In case the PR introduces changes that affect users, the documentation has been updated.
  • The code is fully tested and no breaking changes introduced to the core functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant