Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create A Render Deployment Topic Outline #2201

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

themagicianking
Copy link
Collaborator

@themagicianking themagicianking commented Jan 3, 2025

Issue: The deploying folder has set up details for Heroku and Netlify, but not Render which has been used for the past few cohort. However, the Render set up has been in google docs, we need to officially move this into the curriculum.

Feedback Request: I want to make sure my incorporation of notes is relevant and that it's not too lengthy to just include basically the entirety of those notes. I also want to make sure that the way I structured each step isn't too complex; should I split them up further, title them, generalize them more into fewer steps, or leave as is? I'm also wondering what kind of information I should include on db-migration and how in depth I should go.

I have completed the following changes:

  • Created initial file and skeleton of the outline based on past lessons
  • Transferred lesson from google doc to file and adjusted contents to fit lesson format
  • Added pictures from google doc to file
  • Added Auth0 as supplemental resource
  • Added challenges section
  • Added common mistakes section
  • Incorporated notes on Auth0 from Brie in instructions
  • Incorporated notes on a common error in using the dump file from Brie in the common mistakes section

To do:

  • Add information on db-migration

@themagicianking themagicianking self-assigned this Jan 3, 2025
@themagicianking themagicianking linked an issue Jan 3, 2025 that may be closed by this pull request
@themagicianking themagicianking marked this pull request as ready for review January 3, 2025 19:00
@mai-repo mai-repo self-requested a review January 3, 2025 20:07
Copy link
Collaborator

@mai-repo mai-repo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@themagicianking Looks good! My only suggestion would be to add the media type for the links the supplemental materials section. For example:

@themagicianking
Copy link
Collaborator Author

@mai-repo Thank you! Implemented in this commit. I didn't add media type to the lessons since those typically do not have a media type attached.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review or Testing
Development

Successfully merging this pull request may close these issues.

Create a Render Deployment Topic Outline
2 participants