metrics for jobs #11
Open
metrics for jobs #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aodhom
reviewed
Feb 12, 2025
worker_pool.go
Outdated
| err := next() | ||
| executionTime := time.Since(jobStart) | ||
|
|
||
| wp.dd.Histogram("job.execution_time", executionTime, []string{"job:" + job.Name, "jobID:" + job.ID}) |
There was a problem hiding this comment.
We have to be a bit cautious about cardinality when it comes to Datadog custom metrics @Conor-Pas
I'm not 100% sure how many unique combos jobId will generate here.
Maybe we can deploy, monitor and revert if we see issues.
There was a problem hiding this comment.
JobName should be enough, so I can get rid of jobID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a middleware to track job metrics https://github.com/Teamwork/work/pull/11/files#diff-bd8cc636f459b2711eebe934ff17a374d2531d25494f777d6ae9c79356b872bbR6
https://digitalcrew.teamwork.com/app/tasks/24149677