[REFACTOR] CertificationController & GithubController Facade &DCI 패턴 적용 #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 파사드 패턴 적용에 따라 인터페이스 추가 및 구현체 적용 - 이름 변경
- 파사드 패턴 적용에 따른 인터페이스 및 구현체 적용 - 이름 변경
- InstanceProvider 의존에서 InstanceService 의존으로 변경
- Facade에서 Service만 의존하도록 리팩토링
- 깃허브와 관련된 부분은 GithubService로 이동 - 도메인에 해당하는 비지니스 로직 이동
SSung023
added
💡feature
1 task
Test Results158 files 158 suites 45s ⏱️ Results for commit e8366ac. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 타입(하나 이상의 PR 타입을 선택해주세요)
☑ 기능 추가
□ 기능 삭제
☑ 리팩토링
□ 버그 수정
□ 의존성, 환경 변수, 빌드 관련 코드 업데이트
반영 브랜치
refactor/236-Certification-Facade→main변경 사항
테스트 결과
연관된 이슈
#236
리뷰 요구사항(선택)