Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add playsinline attribute to video tag #3938

Closed
wants to merge 1 commit into from
Closed

Add playsinline attribute to video tag #3938

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/VideoPlayer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
class="relative max-h-screen w-full flex justify-center"
:class="{ 'player-container': !isEmbed }"
>
<video ref="videoEl" class="w-full" data-shaka-player :autoplay="shouldAutoPlay" :loop="selectedAutoLoop" />
<video ref="videoEl" class="w-full" data-shaka-player :autoplay="shouldAutoPlay" :loop="selectedAutoLoop" playsinline />

Check failure on line 8 in src/components/VideoPlayer.vue

View workflow job for this annotation

GitHub Actions / build 

Replace `·ref="videoEl"·class="w-full"·data-shaka-player·:autoplay="shouldAutoPlay"·:loop="selectedAutoLoop"·playsinline` with `⏎············ref="videoEl"⏎············class="w-full"⏎············data-shaka-player⏎············:autoplay="shouldAutoPlay"⏎············:loop="selectedAutoLoop"⏎············playsinline⏎·······`

Check failure on line 8 in src/components/VideoPlayer.vue

View workflow job for this annotation

GitHub Actions / build 

Replace `·ref="videoEl"·class="w-full"·data-shaka-player·:autoplay="shouldAutoPlay"·:loop="selectedAutoLoop"·playsinline` with `⏎············ref="videoEl"⏎············class="w-full"⏎············data-shaka-player⏎············:autoplay="shouldAutoPlay"⏎············:loop="selectedAutoLoop"⏎············playsinline⏎·······`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·ref="videoEl"·class="w-full"·data-shaka-player·:autoplay="shouldAutoPlay"·:loop="selectedAutoLoop"·playsinline with ⏎············ref="videoEl"⏎············class="w-full"⏎············data-shaka-player⏎············:autoplay="shouldAutoPlay"⏎············:loop="selectedAutoLoop"⏎············playsinline⏎·······

Suggested change
<video ref="videoEl" class="w-full" data-shaka-player :autoplay="shouldAutoPlay" :loop="selectedAutoLoop" playsinline />
<video
ref="videoEl"
class="w-full"
data-shaka-player
:autoplay="shouldAutoPlay"
:loop="selectedAutoLoop"
playsinline
/>

<span
id="preview-container"
ref="previewContainer"
Expand Down
Loading