Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign reminder-related commands #321

Merged
merged 7 commits into from
Jul 3, 2024
Merged

Redesign reminder-related commands #321

merged 7 commits into from
Jul 3, 2024

Conversation

mctaylors
Copy link
Member

@mctaylors mctaylors commented Jun 25, 2024 •
edited
Loading

In this PR, I redesigned the reminder-related commands and they will now have a quote block instead of a inline code block (to avoid some visual bugs). Except /listremind. It just has the inline code block removed.
image

@mctaylors mctaylors added the type: fix PRs that fix bugs, typos, style issues. label Jun 25, 2024
@mctaylors mctaylors requested a review from a team as a code owner June 25, 2024 17:37
@pull-request-size pull-request-size bot added the size/XS PRs that change <20 lines. label Jun 25, 2024
@Octol1ttle
Copy link
Member

I have the following concerns:
a) If we want to fight formatting abuse, we need to do it everywhere, not just in /remind
b) Wouldn't it be better to remove any offending characters automatically instead of having the user remove the characters?
c) Is it worth it fighting this? We can ignore this, there aren't any major issues caused by this. At the very least, we can just never use inline code blocks like we do in other places

@pull-request-size pull-request-size bot added size/S PRs that change 20-100 lines. and removed size/XS PRs that change <20 lines. labels Jun 30, 2024
@mctaylors
Copy link
Member Author

a) If we want to fight formatting abuse, we need to do it everywhere, not just in /remind

can you tell me where Octobot also shows user input in inline code block?

@Octol1ttle
Copy link
Member

can you tell me where Octobot also shows user input in inline code block?

Ctrl+Shift+F .InlineCode(

@mctaylors
Copy link
Member Author

can you tell me where Octobot also shows user input in inline code block?

Ctrl+Shift+F .InlineCode(

Well, that doesn't seem quite right. The solution you propose affects all inline code blocks, not just user input in the inline code blocks.

Anyway, since we didn't used inline code blocks in /ban, /mute, /kick commands, I'll just remove .InlineCode() things in reminder-related commands.

mctaylors added 2 commits July 1, 2024 20:32
@mctaylors
i love reverting commits
2aaed56 
This reverts commit a466111.
@mctaylors
extremely high quality (not) workaround
1dffff2 
didn't even tested it yet
@pull-request-size pull-request-size bot added size/XS PRs that change <20 lines. and removed size/S PRs that change 20-100 lines. labels Jul 1, 2024
@pull-request-size pull-request-size bot added size/S PRs that change 20-100 lines. and removed size/XS PRs that change <20 lines. labels Jul 1, 2024
@mctaylors mctaylors changed the title Ban backticks in /remind Redesign reminder-related commands Jul 1, 2024
@mctaylors
Copy link
Member Author

Anyway, since we didn't used inline code blocks in /ban, /mute, /kick commands, I'll just remove .InlineCode() things in reminder-related commands.

Didn't like this idea either.

@mctaylors mctaylors added type: change PRs that update current functionality without adding new features or fixing any bugs and removed type: fix PRs that fix bugs, typos, style issues. labels Jul 2, 2024
@Octol1ttle
Copy link
Member

Please update your pull request description and provide new screenshots.

@mctaylors
Copy link
Member Author

Please update your pull request description and provide new screenshots.

Done. Sorry for the delay.

@mctaylors mctaylors enabled auto-merge (squash) July 3, 2024 17:08
@Octol1ttle Octol1ttle self-assigned this Jul 3, 2024
@mctaylors mctaylors merged commit 07e8784 into master Jul 3, 2024
1 check passed
@mctaylors mctaylors deleted the ban-backticks-in-remind branch July 3, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Octol1ttle Octol1ttle Octol1ttle approved these changes

Assignees

@Octol1ttle Octol1ttle

Labels
size/S PRs that change 20-100 lines. type: change PRs that update current functionality without adding new features or fixing any bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mctaylors @Octol1ttle