Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seal implicitly used classes #309

Merged
merged 1 commit into from
May 23, 2024
Merged

Seal implicitly used classes #309

merged 1 commit into from
May 23, 2024

Conversation

Octol1ttle
Copy link
Member

Apparently the [UsedImplicitly] annotation suppresses the "Class has no inheritors and can be marked sealed" warning. Cool to know.

@Octol1ttle Octol1ttle added the type: refactor/style Changes that improve code quality and styling without affecting functionality label May 18, 2024
@Octol1ttle Octol1ttle requested a review from a team as a code owner May 18, 2024 16:19
@pull-request-size pull-request-size bot added the size/S PRs that change 20-100 lines. label May 18, 2024
@mctaylors mctaylors self-assigned this May 23, 2024
@Octol1ttle Octol1ttle force-pushed the seallllllllllllll branch from 38756b4 to 796e03a Compare May 23, 2024 12:40
@Octol1ttle Octol1ttle requested a review from mctaylors May 23, 2024 12:41
Copy link
Member

@mctaylors mctaylors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sealed to me

@Octol1ttle Octol1ttle merged commit d03e250 into master May 23, 2024
1 check passed
@Octol1ttle Octol1ttle deleted the seallllllllllllll branch May 23, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S PRs that change 20-100 lines. type: refactor/style Changes that improve code quality and styling without affecting functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants