Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate /*info commands from ToolsCommandGroup #308

Merged
merged 1 commit into from
May 18, 2024
Merged

Separate /*info commands from ToolsCommandGroup #308

merged 1 commit into from
May 18, 2024

Conversation

Octol1ttle
Copy link
Member

who tf thought that putting 1234915912 methods responsible for 23981 commands in a single class was a good idea???????

@Octol1ttle Octol1ttle added the type: refactor/style Changes that improve code quality and styling without affecting functionality label May 18, 2024
@Octol1ttle Octol1ttle requested a review from a team as a code owner May 18, 2024 16:09
@pull-request-size pull-request-size bot added the size/L PRs that change 200-1000 lines. label May 18, 2024
@mctaylors mctaylors self-assigned this May 18, 2024
mctaylors
mctaylors approved these changes May 18, 2024
View reviewed changes
Copy link
Member

@mctaylors mctaylors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

who tf thought that putting 1234915912 methods responsible for 23981 commands in a single class was a good idea???????

who tf approved those prs then

@Octol1ttle Octol1ttle merged commit ebcdcb3 into master May 18, 2024
1 check passed
@Octol1ttle Octol1ttle deleted the move-info-commands branch May 18, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mctaylors mctaylors mctaylors approved these changes

Assignees

@mctaylors mctaylors

Labels
size/L PRs that change 200-1000 lines. type: refactor/style Changes that improve code quality and styling without affecting functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Octol1ttle @mctaylors