Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply official naming guidelines to Octobot #306

Merged
merged 4 commits into from
May 16, 2024
Merged

Apply official naming guidelines to Octobot #306

merged 4 commits into from
May 16, 2024

Conversation

Octol1ttle
Copy link
Member

  1. The root namespace was changed from Octobot to TeamOctolings.Octobot:

DO prefix namespace names with a company name to prevent namespaces from different companies from having the same name.

  1. Octobot.cs was renamed to Program.cs:

DO NOT use the same name for a namespace and a type in that namespace.

  1. IOption, Option were renamed to IGuildOption and GuildOption respectively:

DO NOT introduce generic type names such as Element, Node, Log, and Message.

  1. Utility was moved out of the Services namespace. It didn't belong there anyway
  2. Program static fields were moved to Utility
  3. Localisation files were moved back to the project source files. Looks like this fixed Message.Designer.cs code generation

@Octol1ttle Octol1ttle added the type: refactor/style Changes that improve code quality and styling without affecting functionality label May 16, 2024
@Octol1ttle Octol1ttle requested a review from a team as a code owner May 16, 2024 13:41
@pull-request-size pull-request-size bot added the size/L PRs that change 200-1000 lines. label May 16, 2024
@mctaylors mctaylors self-assigned this May 16, 2024
@Octol1ttle Octol1ttle requested a review from mctaylors May 16, 2024 15:33
mctaylors
mctaylors approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@mctaylors mctaylors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whatever

@Octol1ttle Octol1ttle merged commit 793afd0 into master May 16, 2024
1 check passed
@Octol1ttle Octol1ttle deleted the move-root branch May 16, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mctaylors mctaylors mctaylors approved these changes

Assignees

@mctaylors mctaylors

Labels
size/L PRs that change 200-1000 lines. type: refactor/style Changes that improve code quality and styling without affecting functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Octol1ttle @mctaylors