Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] 배경사진 추가 및 적용 #63

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Conversation

no1msh
Copy link
Contributor

@no1msh no1msh commented Sep 4, 2024

resolved #62

AS-IS

검정 배경화면을

TO-BE

그라데이션을 넣은 배경화면으로 변경합니다.

KEY-POINT

  • 검정 배경을 전부 없애고 적용하였습니다.

SCREENSHOT (Optional)

image

@no1msh no1msh requested a review from librarywon September 4, 2024 08:05
@no1msh no1msh self-assigned this Sep 4, 2024
Copy link
Contributor

@librarywon librarywon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코멘트 하나 확인 부탁드립니다 ㅎㅎ

@@ -72,7 +73,7 @@ fun HY2Theme(
val window = (view.context as Activity).window
val insetsController = WindowCompat.getInsetsController(window, view)
val statusBarColor = colorScheme.background.toArgb()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이렇게 바뀌면 이 변수는 삭제해도 괜찮지 않을까 생각이 듭니다!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영하였습니다. 까먹었네요

@no1msh no1msh merged commit ba43e35 into develop Sep 4, 2024
1 check passed
@librarywon librarywon deleted the Feature/#62-background branch September 5, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] 배경 이미지를 적용합니다.
2 participants