[Feature][Fix] 타임 피커에서 미래시간을 선택하지 못하게 합니다. + AM, PM 하드코딩을 변경합니다. #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
librarywon
approved these changes
Sep 3, 2024
| @@ -92,21 +92,34 @@ fun HY2TimePicker( | |||
| .wrapContentHeight() | |||
| .background(Gray800, RoundedCornerShape(DIALOG_CORNER_RADIUS.dp)), | |||
| ) { | |||
| val hours: List<String> = | |||
| val meridiem: List<String> = | |||
There was a problem hiding this comment.
정오가 아니라 AM, PM 이런게 영어로 저겁니다!
There was a problem hiding this comment.
엥 번역기에서는 정오라는 뜻이던데 아니였군요.. 어쩐지 리스트더라
…ker-component # Conflicts: # main-data/src/main/java/com/teamhy2/main/data/repository/DefaultStudyDayRepository.kt # main-presentation/src/main/java/com/teamhy2/feature/main/component/RunningTimerComponent.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved #55
resolved #59
AS-IS
�AM, PM이 하드코딩 되어있고, 타임 피커에서 미래시간을 선택할 수 있습니다.
TO-BE
다 고칩니다.
KEY-POINT
이게 아무래도 컴포넌트 자체가 12h AM/PM 형식이니 굉장히 엣지 케이스도 많고 더군다나 am과 pm이 겹쳐지는 시간대는 아마 더 심할 것으로 예상되어서 기획 + 디자인을 바꿔보는 것을 건의하고 싶습니다.
SCREENSHOT (Optional)