Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat [#188] 푸시알림기능 구현 완료 #190

Merged
merged 4 commits into from
Jun 16, 2024

Conversation

binisnil
Copy link
Contributor

👻 PULL REQUEST

💻 작업한 내용

  • FCM 푸시알림 구현 완료했습니다
  • UserInfo의 구조를 FCM 푸시알림 구현의 필요에 의해서 수정했습니다! 이에 따라 제 구현부가 아닌 파일에서 수정이 많이 발생했는데, 참고 부탁드립니다
  • AppDelegate, HomeViewController, HomeViewModel 위주로 봐주시면 됩니다!

💡 참고사항

  • 현재 백그라운드 상태에서 푸시알림이 왔을 때, 홈 -> 알림이 온 댓글 페이지로 이동이 안됩니다 ㅠㅠ QA 이후에 원인파악해서 수정하도록 하겠습니다!
  • GoogleService.info-plist에 google app ID와 관련된 정보가 있어서 올리지 않았습니다. 개인적으로 파일 전달해드리도록 하겠습니다

📸 스크린샷

기능 스크린샷
GIF

📟 관련 이슈

@binisnil binisnil added the Feat label Jun 14, 2024
@binisnil binisnil requested a review from boogios June 14, 2024 10:35
@binisnil binisnil self-assigned this Jun 14, 2024
Copy link
Member

@boogios boogios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3
푸쉬 알림 너무 고생하셨습니다!!! 푸쉬 알림 너무 기대되네여!!!ㅎㅎㅎ

}
}

func checkUserLoginState() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2
안쓰는 함수들은 지워주셔도 될 것 같아요~! 다음에 반영해주셔도 됩니다!

@@ -246,4 +257,60 @@ extension HomeViewModel {
return nil
}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3
멀티파트 통신 어렵던데 고생많으셨습니다!!ㅠㅠㅠ

userProfileImage: loadUserData()?.userProfileImage ?? StringLiterals.Network.baseImageURL))
userProfileImage: loadUserData()?.userProfileImage ?? StringLiterals.Network.baseImageURL,
fcmToken: loadUserData()?.fcmToken ?? "",
isPushAlarmAllowed: loadUserData()?.isPushAlarmAllowed ?? false))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3
모든 부분 수정하시느라 고생많으셨군요!!

@boogios boogios merged commit b599b06 into develop Jun 16, 2024
1 check passed
@boogios boogios deleted the feat/#188-pushNotification branch June 16, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] 푸시알림 구현
2 participants