Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix/127 - 서류생성로딩처리,유효성검사강화 #158

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

MrMirror21
Copy link
Contributor

Related issue 🛠

#127

Work Description ✏️

  • 유학생 문서 컨펌, 최종 생성 시 로딩 UI 적용
  • 유학생 시간제근로허가서 작성 시 유효성 검사 강화 적용(기존: 모두 입력하면 통과 => 신규 : 항목별 양식에 맞춰 작성해야 통과)
스크린샷 2025-01-21 오후 11 34 30 스크린샷 2025-01-21 오후 11 34 30
  • 회원가입 과정 step indicator 변경 디자인 적용
스크린샷 2025-01-21 오후 11 34 30 스크린샷 2025-01-21 오후 11 34 56

Uncompleted Tasks 😅

To Reviewers 📢

유효성검사 함수의 리팩토링을 진행하려했으나 우리 문서가 지원하는 타입이 너무 많아서 배보다 배꼽이 커진 관계로 원래 방식대로 선회했습니다. 다음 PR에는 현재 작성한 방식으로 통일할 예정입니다.

@MrMirror21 MrMirror21 added 🐞 BugFix Something isn't working ✨ Feature New feature or request 🎨 Html&CSS Markup & Styles labels Jan 21, 2025
@MrMirror21 MrMirror21 requested a review from naarang January 21, 2025 14:42
@MrMirror21 MrMirror21 self-assigned this Jan 21, 2025
Copy link
Contributor

@naarang naarang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고많으셨습니다~!! 저도 작업해서 얼른 pr 올릴게요☺️

@MrMirror21 MrMirror21 merged commit ce6af08 into main Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 BugFix Something isn't working ✨ Feature New feature or request 🎨 Html&CSS Markup & Styles
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants