Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrMirror21
added
🐞 BugFix
naarang
reviewed
Jan 20, 2025
src/components/Common/Input.tsx
Outdated
| @@ -18,6 +18,7 @@ type InputProps = { | |||
| placeholder: string; // 플레이스홀더 텍스트 | |||
| value: string | null; // 입력 필드의 현재 값 | |||
| onChange: (value: string) => void; // 입력값 변경 시 호출될 함수 | |||
| onBlur?: (value: string) => void; // 입력 필드에서 포커스가 빠져나갈 때 호출될 함수 (선택적) | |||
There was a problem hiding this comment.
안그래도 요즘 스터디에서 컴포넌트나 모듈 분리의 기준에 대한 내용을 진행했었는데, 적절하지 않은 예시가 딱 이 컴포넌트더라구요.. 🥲 좀 더 세부적인 레벨의 요소들로 분리해서 재조립해야하나 싶어요
There was a problem hiding this comment.
이 부분 한 번 얘기해보죠!!ㅎㅎㅎ 관련 스터디 내용도 나중에 알려주세용!😉
| @@ -86,7 +88,7 @@ export const validateEmployerInformation = ( | |||
| // 시급 유효성 검사(0이 아닌지) | |||
| if ( | |||
| !info.hourly_rate || | |||
| extractNumbersAsNumber(String(info.hourly_rate)) === 0 | |||
| extractNumbersAsNumber(String(info.hourly_rate)) < MINIMUM_HOURLY_RATE | |||
There was a problem hiding this comment.
저도 연도마다 시급이 변해야하다보니 상수화가 좋다고 생각했습니다~👍
src/utils/document.ts
Outdated
| setWarning, | ||
| }: { | ||
| value: string; | ||
| setWarning: React.Dispatch<React.SetStateAction<boolean>>; |
There was a problem hiding this comment.
제가 알기로 React.Dispatch 이렇게 바로 넘기는 것보다 (value:string) => void 형식의 함수를 넘기는 것이 더 안정적이다고 알고 있어요!
There was a problem hiding this comment.
이전엔 단순히 작성하기 쉬워서 순수 함수 타입을 넘긴다고 생각했는데, 가독성이나 결합도 측면에서도 확실히 더 좋은 방식이었네요. 수정하겠습니다~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
#127
Work Description ✏️
Uncompleted Tasks 😅
To Reviewers 📢