-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
End Contest Button added #10
base: b1
Are you sure you want to change the base?
Conversation
db_conn.py
Outdated
@@ -3,12 +3,12 @@ | |||
|
|||
# ADD URI STRING HERE ################################# | |||
# set production False, if you want to contribute to this repo and make changes | |||
production = True | |||
production = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this required? It would better be True
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this should be True
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vikasnitd Set the production
variable to True
and send the commit again
db_conn.py
Outdated
|
||
uri_string = "" | ||
|
||
######################################################### | ||
|
||
client = pymongo.MongoClient(uri_string) | ||
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this change. You have added a trailing whitespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vikasnitd remove this trailing whitespace.
templates/base-login.html
Outdated
@@ -40,8 +40,8 @@ | |||
<li class="nav-item"> | |||
<a class="nav-link" href="/standings">Current Leaderboard</a> | |||
</li> | |||
<li class="nav-item"> | |||
<a class="nav-link" href="/end_contest"><b><em>End Contest</em></b></a> | |||
<li class="nav-item"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove trailing whitespace here.
requirements.txt
Outdated
@@ -7,9 +7,7 @@ itsdangerous==0.24 | |||
Jinja2==2.10 | |||
language-selector==0.1 | |||
MarkupSafe==1.0 | |||
pygobject==3.20.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know how the changes in requirements.txt
matters for this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vikasnitd undo this change , it does not relate to PR.
Looks good now. There is |
No description provided.