Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End Contest Button added #10

Open
wants to merge 4 commits into
base: b1
Choose a base branch
from
Open

Conversation

vikasnitd
Copy link

No description provided.

@vishvanath45 vishvanath45 requested a review from hasan356 October 27, 2018 05:11
db_conn.py Outdated
@@ -3,12 +3,12 @@

# ADD URI STRING HERE #################################
# set production False, if you want to contribute to this repo and make changes
production = True
production = False

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required? It would better be True.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this should be True.

Copy link
Collaborator

@hasan356 hasan356 Oct 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vikasnitd Set the production variable to True and send the commit again

db_conn.py Outdated

uri_string = ""

#########################################################

client = pymongo.MongoClient(uri_string)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this change. You have added a trailing whitespace.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vikasnitd remove this trailing whitespace.

@@ -40,8 +40,8 @@
<li class="nav-item">
<a class="nav-link" href="/standings">Current Leaderboard</a>
</li>
<li class="nav-item">
<a class="nav-link" href="/end_contest"><b><em>End Contest</em></b></a>
<li class="nav-item">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove trailing whitespace here.

requirements.txt Outdated
@@ -7,9 +7,7 @@ itsdangerous==0.24
Jinja2==2.10
language-selector==0.1
MarkupSafe==1.0
pygobject==3.20.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know how the changes in requirements.txt matters for this PR?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vikasnitd undo this change , it does not relate to PR.

@Compro-Prasad
Copy link

Looks good now. There is git commit --amend if you want to update the same commit and do a force push. It will open up your $EDITOR where you can edit the commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants