Feature/#39 add logout #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
level120
requested changes
Oct 29, 2022
backend/src/main/java/org/mapleleaf/backend/exception/JwtAuthenticationEntryPoint.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/org/mapleleaf/backend/jwt/JwtAuthenticationFilter.java
Outdated
Show resolved
Hide resolved
Comment on lines
71
to
77
| public Long getExpiration(String token) { | ||
| Date expiration = Jwts.parser().setSigningKey(Base64.getEncoder().encodeToString(secretKey.getBytes())) | ||
| .parseClaimsJws(token).getBody().getExpiration(); | ||
|
|
||
| Long now = new Date().getTime(); | ||
| return (expiration.getTime() - now); | ||
| } |
There was a problem hiding this comment.
함수 이름을 보면 expiration을 줄 것 같지만 실제 구현은 그렇지 않네요, 메서드 이름을 변경하거나 반환하는 로직을 변경해야 할 것 같아요.
There was a problem hiding this comment.
해당 함수가 반환하는 값이 토큰의 남은 유효기간이라 getExpiration 으로 하였습니다 ! 혹시 getExpirationTime이 더 적합할까요?
There was a problem hiding this comment.
만료 기간 그대로 반환하는것이 아니고 계산해서 반환해주니 후자 getExpirationTime이 좋을 것 같아요
There was a problem hiding this comment.
수정했습니다 ! 😄 반환 값에 맞는 함수명이 맞는지 더 신경쓰면서 코드 작성하겠습니답 ~!
level120
reviewed
Oct 29, 2022
Comment on lines
+79
to
+83
| public boolean isTokenLogout(String token) { | ||
| String isLogout = (String) redisTemplate.opsForValue().get(token); | ||
| if (StringUtils.hasText(isLogout)) throw new LoggedOutTokenException(); | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Suggested change
| public boolean isTokenLogout(String token) { | |
| String isLogout = (String) redisTemplate.opsForValue().get(token); | |
| if (StringUtils.hasText(isLogout)) throw new LoggedOutTokenException(); | |
| return true; | |
| } | |
| public boolean isTokenLogout(String token) { | |
| String isLogout = (String) redisTemplate.opsForValue().get(token); | |
| return !StringUtils.hasText(isLogout); | |
| } |
There was a problem hiding this comment.
이것은 제가 주말에 다시 고민해보고 수정해도 괜찮을까요?
There was a problem hiding this comment.
요건 만약에 진행하신다면 별도 이슈를 만들어서 하시죠~
level120
reviewed
Nov 1, 2022
backend/src/main/java/org/mapleleaf/backend/exception/JwtAuthenticationEntryPoint.java
Outdated
Show resolved
Hide resolved
Comment on lines
+79
to
+83
| public boolean isTokenLogout(String token) { | ||
| String isLogout = (String) redisTemplate.opsForValue().get(token); | ||
| if (StringUtils.hasText(isLogout)) throw new LoggedOutTokenException(); | ||
| return true; | ||
| } |
403: 권한 없음, 401: 인증 실패
level120
approved these changes
Nov 4, 2022
leedonggyu1848
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
로그인 성공 후 answer 조회
토큰과 함께 로그아웃 요청
로그아웃 시 사용한 토큰으로 answer 조회
