Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

커리큘럼 뷰 (메인, 상세) 디테일 작업 #70

Merged
merged 10 commits into from
Jul 20, 2023

Conversation

wateralsie
Copy link
Member

@wateralsie wateralsie commented Jul 20, 2023

Related issue

Description

Design

  • progress bar lottie 추가
  • 그림자, 그라데이션 추가
  • 디데이 위치값 기기대응
  • 상단영역 변경사항 반영

기능

  • 뷰 들어갔을 때 스크롤 시작 지점 임신주수에 맞게 설정
  • 메인 -> 상세 로직
  • 상세 -> 메인 로직

PR point

  • 메인 -> 상세 로 넘어갈 때 임신주수 int 형태로 intent를 통해 넘겨줍니다

Screenshot

2023-07-20.3.19.34.mov

@wateralsie wateralsie requested a review from SeonHwan-Kim July 20, 2023 06:17
@wateralsie wateralsie self-assigned this Jul 20, 2023
Copy link
Contributor

@SeonHwan-Kim SeonHwan-Kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿입니당

@@ -28,6 +28,12 @@ class CourseDetailActivity :
initRecyclerView()
}

override fun addListeners() {
binding.btnCourseWeeklyBack.setOnClickListener {
finish()
Copy link
Contributor

@SeonHwan-Kim SeonHwan-Kim Jul 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
finish()
if(!isFinishing) finish()

@SeonHwan-Kim SeonHwan-Kim merged commit 6cfee93 into develop Jul 20, 2023
@SeonHwan-Kim SeonHwan-Kim deleted the feature/course-design-modify branch July 20, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

메인 커리큘럼 뷰 수정사항 반영
2 participants