Order #44
Open
Order #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/com/insert/ogbsm/infra/error/exception/ErrorCode.java
qlido
approved these changes
Oct 2, 2023
| Page<Comment> findByPostIdOrderByLikeDesc(Long postId, Long userId, Pageable pageable); | ||
|
|
||
| @Query("SELECT c FROM Comment c WHERE c.postId = :postId ORDER BY CASE WHEN c.userId = :userId THEN 0 ELSE 1 END, c.createdAt ASC") | ||
| Page<Comment> findByPostOrderByCreatedAtDesc(Long postId, Long userId, Pageable pageable); |
There was a problem hiding this comment.
Pageable에 OrderBy를 사용하지 않은 이유가 있나요??
| public class TimeTableProvider { | ||
| private final OkHttpClient httpClient; | ||
|
|
||
| @Value("${env.neis.time_table_url}") |
There was a problem hiding this comment.
이런 env에 직접 접근하는건 지금 cd에 문제를 야기 할 수 있으니 바꾸어주시면 감사하겠습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.