refactor(coin): coin 도메인 리팩토링 및 테스트 코드 작성 #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 29 commits
April 24, 2024 19:43
hw9402
changed the title
qlido
previously approved these changes
Apr 30, 2024
...in/java/com/project/bumawiki/domain/coin/domain/TradeWithoutTradeStatusAndCoinAccountId.java
Outdated
Show resolved
Hide resolved
src/test/java/com/project/bumawiki/domain/coin/service/QueryCoinServiceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/project/bumawiki/domain/coin/service/QueryCoinServiceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/project/bumawiki/global/service/FixtureGenerator.java
Outdated
Show resolved
Hide resolved
src/main/java/com/project/bumawiki/domain/coin/service/PriceScheduler.java
Outdated
Show resolved
Hide resolved
src/main/java/com/project/bumawiki/domain/coin/service/CommandCoinService.java
Outdated
Show resolved
Hide resolved
|
TradeWithoutTradeStatusAndCoinAccountId 가 정확하지만 한번에 읽히지 않는다는 단점이 있는거 같아요. |
src/main/java/com/project/bumawiki/domain/coin/implementation/CoinAccountReader.java
Outdated
Show resolved
Hide resolved
src/main/java/com/project/bumawiki/domain/coin/implementation/CoinAccountValidator.java
Show resolved
Hide resolved
src/main/java/com/project/bumawiki/domain/coin/service/CommandCoinService.java
Outdated
Show resolved
Hide resolved
다시 한 번 생각해보겠습니다! |
jacobhboy
requested changes
Apr 30, 2024
src/main/java/com/project/bumawiki/domain/coin/service/CommandCoinService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/project/bumawiki/domain/coin/service/CommandCoinService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/project/bumawiki/domain/coin/service/PriceScheduler.java
Outdated
Show resolved
Hide resolved
Comment on lines
+42
to
+65
| public List<Price> getPriceByPeriod(String period) { | ||
| switch (period) { | ||
| case "full" -> { | ||
| return priceReader.findAllByOrderByStartedTime(); | ||
| } | ||
| case "halfMonth" -> { | ||
| LocalDateTime twoWeeksAgo = LocalDateTime.now().minusWeeks(2); | ||
| return priceReader.findAllAfterStartedTime(twoWeeksAgo); | ||
| } | ||
| case "week" -> { | ||
| LocalDateTime oneWeekAgo = LocalDateTime.now().minusWeeks(1); | ||
| return priceReader.findAllAfterStartedTime(oneWeekAgo); | ||
| } | ||
| case "day" -> { | ||
| LocalDateTime oneDayAgo = LocalDateTime.now().minusDays(1); | ||
| return priceReader.findAllAfterStartedTime(oneDayAgo); | ||
| } | ||
| case "halfDay" -> { | ||
| LocalDateTime halfDayAgo = LocalDateTime.now().minusHours(12); | ||
| return priceReader.findAllAfterStartedTime(halfDayAgo); | ||
| } | ||
| case "threeHours" -> { | ||
| LocalDateTime threeHoursAgo = LocalDateTime.now().minusHours(3); | ||
| return priceReader.findAllAfterStartedTime(threeHoursAgo); |
There was a problem hiding this comment.
항상 이런 코드를 볼 때 마다 느끼는 것인데, 더 좋은 방법이 없을까요?
src/test/java/com/project/bumawiki/domain/coin/service/QueryCoinServiceTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/project/bumawiki/domain/coin/service/QueryCoinServiceTest.java
Show resolved
Hide resolved
added 9 commits
April 30, 2024 20:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #92
리팩토링도 리팩토링이지만 테스트 코드를 중점적으로 봐주시면 감사하겠습니다!
양이 많기도 했고 시간도 조금 부족했어서 하드 코딩한 부분들이 좀 있을 겁니다..
진행한 작업
이외에
코드 리뷰 진행 중 Read-only Transaction에서 save메서드를 사용한 기존 코드로 인해 아래와 같은 에러가 떴던 부분을 수정했습니다!