Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: seatService 리팩터링 #244

Merged
merged 12 commits into from
Jan 12, 2024
Merged

refactor: seatService 리팩터링 #244

merged 12 commits into from
Jan 12, 2024

Conversation

annahxxl
Copy link
Collaborator

@annahxxl annahxxl commented Jan 12, 2024 •
edited
Loading

구현 기능

  • RedisOperator 유틸클래스로 레디스 연산 로직 매핑
  • redisOperator 주입받아 사용하는 클래스들은 Manager로 네임 변경
    • 파일 위치는 고민입니다! util로 바라보기엔 각 도메인에서만 사용되긴 해서요
  • myOrder entryLimit 반영하여 계산하도록 수정
  • 매직넘버 우선 상수로 분리
  • 좌석 상태명 변경 SELECTED -> HOLDING

resolve: #231

Hanna added 12 commits January 12, 2024 11:17
@annahxxl annahxxl added refactor 리팩터링 booking 예매 labels Jan 12, 2024
@annahxxl annahxxl requested a review from byulcode January 12, 2024 12:29
@annahxxl annahxxl self-assigned this Jan 12, 2024
@byulcode byulcode merged commit 7ba65fe into main Jan 12, 2024
1 check passed
@byulcode byulcode deleted the booking/231 branch January 12, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byulcode byulcode byulcode approved these changes

Assignees

@annahxxl annahxxl

Labels
booking 예매 refactor 리팩터링
Projects
No open projects
SPRINT3 (01.05~01.11)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: seatService 리팩터링
2 participants
@annahxxl @byulcode