Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 공연 기능 추가 #22

Merged
merged 8 commits into from
Dec 24, 2023
Merged

feat: 공연 기능 추가 #22

merged 8 commits into from
Dec 24, 2023

Conversation

park0jae
Copy link
Member

구현 기능

  • 공연 관리 기능을 구현합니다. (간단한 CRUD)
    • 공연 등록 (createEvent)
    • 공연 단건 조회 (getEventById)
    • 공연 수정 (updateEvent)
    • 공연 삭제 (deleteEvent)

참고 사항

  • core쪽 ErrorResponse 클래스 필드 부분에 final 키워드를 추가해줬습니다.
  • 아직 공연장 등록 기능이 구현되지 않아서, 우선 공연 등록 시 공연장 등록 부분은 null로 처리하였고, 구현 후 교체하면 될 것 같습니다.
  • validation 부분은 추후에 추가할 예정입니다.

resolve: #12

@park0jae park0jae added feature 기능 event 공연 labels Dec 24, 2023
@park0jae park0jae requested a review from KarmaPol December 24, 2023 07:10
@park0jae park0jae self-assigned this Dec 24, 2023
KarmaPol
KarmaPol reviewed Dec 24, 2023
View reviewed changes
Copy link
Member

@KarmaPol KarmaPol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 잘 읽었습니다

api/api-event/src/main/java/com/pgms/apievent/exception/EventErrorCode.java

EVENT_NOT_FOUND("NOT FOUND", HttpStatus.NOT_FOUND, "존재하지 않는 공연입니다."),
ALREADY_EXIST_EVENT("DUPLICATE EVENT", HttpStatus.CONFLICT, "이미 존재하는 공연입니다."),
VALIDATION_FAILED("VALIDATION FAILED", HttpStatus.BAD_REQUEST, "입력값에 대한 검증에 실패했습니다.");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

api/api-event/src/main/java/com/pgms/apievent/exception/EventGlobalExceptionHandler.java
ErrorResponse errorResponse = new ErrorResponse(VALIDATION_FAILED.getErrorCode(), errorMessage);
fieldErrors.forEach(error -> errorResponse.addValidation(error.getField(), error.getDefaultMessage()));
return ResponseEntity.status(ex.getStatusCode()).body(errorResponse);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@park0jae park0jae merged commit 833862b into main Dec 24, 2023
1 check passed
@KarmaPol KarmaPol changed the title feat: 공연장 기능 추가 feat: 공연 기능 추가 Dec 24, 2023
@park0jae park0jae deleted the event/12 branch December 26, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KarmaPol KarmaPol KarmaPol approved these changes

Assignees

@park0jae park0jae

Labels
event 공연 feature 기능
Projects
No open projects
SPRINT1 (12.22~12.28)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: 공연 관리 - 공연 등록 , 수정, 삭제 기능 구현
2 participants
@park0jae @KarmaPol