Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the feature to read permission attributes from LDAP #2303

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

nyuuyn
Copy link
Contributor

@nyuuyn nyuuyn commented Jun 22, 2023

Adds the feature to read permission attributes from LDAP, see also #2302

Sonar Cloud link: https://sonarcloud.io/summary/new_code?id=nyuuyn_taskana&branch=nyuuyn%2Fperms


Release Notes:

Adds the feature to read permission attributes from LDAP via taskana.ldap.userPermissionsAttribute=permission

For the submitter:

Verified by the reviewer:

@nyuuyn nyuuyn changed the title Nyuuyn/perms Adds the feature to read permission attributes from LDAP Jun 22, 2023
Copy link
Contributor

@ryzheboka ryzheboka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work!

The standard for TASKANA is to have one commit for one PR. Two or more commits are in case the two commits are not connected. For example, the second commit is renaming some unrelated tests (too small in order to open a new PR for that). Could you squash your commits and rename the resulting commit? Our new naming guide for commits is:
"Closes #XXXX - bla bla bla"
XXXX is the issue number. This way, the issue gets closed automatically.

Did you adjust assigment of permitted domains? Before this feature, permitted domains were only dependant on groups. I might have overseen this change in the PR.

@nyuuyn nyuuyn force-pushed the nyuuyn/perms branch 2 times, most recently from f885c82 to 2a778f7 Compare June 27, 2023 14:57
@nyuuyn nyuuyn force-pushed the nyuuyn/perms branch 4 times, most recently from c47d256 to 5529bad Compare June 30, 2023 09:55
@nyuuyn nyuuyn force-pushed the nyuuyn/perms branch 2 times, most recently from 6729951 to a3660c2 Compare September 1, 2023 07:32
            - Extends LDAP client to read permission attributes from users
            - Extends database schema with PERMISSION_INFO table and sets schema version to 6.4.0
            - Exetends User models (Builder, Mapper,..) to have permission attribute
    	- Determination of Domains is now able to be done via permissions defined on users

    Signed-off-by: Kálmán Képes <[email protected]>
@ryzheboka ryzheboka merged commit 18c34d1 into Taskana:master Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commit Hooks won't work without JIRA Tickets
3 participants