-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the feature to read permission attributes from LDAP #2303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work!
The standard for TASKANA is to have one commit for one PR. Two or more commits are in case the two commits are not connected. For example, the second commit is renaming some unrelated tests (too small in order to open a new PR for that). Could you squash your commits and rename the resulting commit? Our new naming guide for commits is:
"Closes #XXXX - bla bla bla"
XXXX is the issue number. This way, the issue gets closed automatically.
Did you adjust assigment of permitted domains? Before this feature, permitted domains were only dependant on groups. I might have overseen this change in the PR.
common/taskana-common/src/main/resources/sql/db2/taskana_schema_update_5.10.0_to_6.2.0_db2.sql
Outdated
Show resolved
Hide resolved
common/taskana-common/src/main/resources/sql/h2/taskana_schema_update_5.10.0_to_6.2.0_h2.sql
Outdated
Show resolved
Hide resolved
...askana-common/src/main/resources/sql/oracle/taskana_schema_update_5.10.0_to_6.2.0_oracle.sql
Outdated
Show resolved
Hide resolved
...na-common/src/main/resources/sql/postgres/taskana_schema_update_5.10.0_to_6.2.0_postgres.sql
Outdated
Show resolved
Hide resolved
common/taskana-common/src/main/resources/sql/db2/taskana_schema_update_5.10.0_to_6.2.0_db2.sql
Outdated
Show resolved
Hide resolved
...askana-common/src/main/resources/sql/oracle/taskana_schema_update_5.10.0_to_6.2.0_oracle.sql
Outdated
Show resolved
Hide resolved
lib/taskana-core/src/main/java/pro/taskana/user/internal/UserMapper.java
Show resolved
Hide resolved
lib/taskana-core/src/main/java/pro/taskana/user/internal/UserMapperSqlProvider.java
Show resolved
Hide resolved
f885c82
to
2a778f7
Compare
...na-common/src/main/resources/sql/postgres/taskana_schema_update_5.10.0_to_6.3.0_postgres.sql
Outdated
Show resolved
Hide resolved
...na-common/src/main/resources/sql/postgres/taskana_schema_update_5.10.0_to_6.3.0_postgres.sql
Outdated
Show resolved
Hide resolved
c47d256
to
5529bad
Compare
common/taskana-common/src/main/resources/sql/db2/taskana_schema_update_5.10.0_to_6.3.0_db2.sql
Outdated
Show resolved
Hide resolved
common/taskana-common/src/main/resources/sql/h2/taskana_schema_update_5.10.0_to_6.3.0_h2.sql
Outdated
Show resolved
Hide resolved
...askana-common/src/main/resources/sql/oracle/taskana_schema_update_5.10.0_to_6.3.0_oracle.sql
Outdated
Show resolved
Hide resolved
...na-common/src/main/resources/sql/postgres/taskana_schema_update_5.10.0_to_6.3.0_postgres.sql
Outdated
Show resolved
Hide resolved
lib/taskana-core-test/src/test/java/acceptance/user/UserServiceAccTest.java
Show resolved
Hide resolved
lib/taskana-core-test/src/test/java/acceptance/user/UserServiceAccTest.java
Outdated
Show resolved
Hide resolved
...spring-example-wildfly/src/test/resources/application-with-additional-user-config.properties
Outdated
Show resolved
Hide resolved
6729951
to
a3660c2
Compare
- Extends LDAP client to read permission attributes from users - Extends database schema with PERMISSION_INFO table and sets schema version to 6.4.0 - Exetends User models (Builder, Mapper,..) to have permission attribute - Determination of Domains is now able to be done via permissions defined on users Signed-off-by: Kálmán Képes <[email protected]>
Adds the feature to read permission attributes from LDAP, see also #2302
Sonar Cloud link: https://sonarcloud.io/summary/new_code?id=nyuuyn_taskana&branch=nyuuyn%2Fperms
Release Notes:
For the submitter:
Verified by the reviewer: