Skip to content
This repository has been archived by the owner on Sep 3, 2024. It is now read-only.

Support --with-cxx option #133

Merged
merged 8 commits into from
Mar 29, 2023

Conversation

youpong
Copy link
Collaborator

@youpong youpong commented Mar 27, 2023

Description

Add following options and environment variable to configure script:

Options:

  • --with-cxx=CXX use CXX to compile
  • -v, --version show version information

Environment variable:

  • CXX C++ compiler command

Related Issue(s)

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #133 (d8eabe8) into main (e9a357a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #133   +/-   ##
=======================================
  Coverage   29.49%   29.49%           
=======================================
  Files           4        4           
  Lines         512      512           
=======================================
  Hits          151      151           
  Misses        361      361           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@youpong
Copy link
Collaborator Author

youpong commented Mar 27, 2023

The current configure script is failing on macOS because it depends on GNU getopt(1).
Please postpone merging this pull request until we can resolve the issue on macOS.

@youpong
Copy link
Collaborator Author

youpong commented Mar 28, 2023

Now, It's ready to merge.

  • Install GNU Getopt(1) on macOS
  • Modify configure script to be compliant with both macOS and Ubuntu.

@youpong youpong requested a review from TanmayPatil105 March 28, 2023 17:07
@TanmayPatil105 TanmayPatil105 merged commit 01a2bec into TanmayPatil105:main Mar 29, 2023
@youpong
Copy link
Collaborator Author

youpong commented Mar 29, 2023

Thunks!
Thanks!

@youpong youpong deleted the feat-llvm-clang branch March 29, 2023 12:49
@youpong youpong mentioned this pull request May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants