improve view flags, handle state update in zoneless

TanStack · Jan 5, 2025 · 144f0b7 · 144f0b7
1 parent 9d57db0
commit 144f0b7
Showing 1 changed file with 6 additions and 12 deletions.
diff --git a/packages/angular-table/src/flex-render.ts b/packages/angular-table/src/flex-render.ts
@@ -112,20 +112,14 @@ export class FlexRenderDirective<TProps extends NonNullable<unknown>>
       return
     }
 
-    console.log('go into do check')
-
-    // TODO: Optimization for V9 / future updates?. We could check for dirty signal changes when
-    //  we are able to detect whether the table state changes here
-    // const isChanged =
+    // TODO: Optimization for V9 / future updates?.
+    //  We could check for dirty signal changes when we are able to detect whether the table state changes here
+    //  const isChanged =
     //   this.renderFlags &
     //   (FlexRenderFlags.DirtySignal | FlexRenderFlags.PropsReferenceChanged)
-    // if (!isChanged) {
-    //   return
-    // }
-    // if (this.renderFlags & FlexRenderFlags.DirtySignal) {
-    //   this.renderFlags &= ~FlexRenderFlags.DirtySignal
-    //   return
-    // }
+    //  if (!isChanged) {
+    //    return
+    //  }
 
     this.renderFlags |= FlexRenderFlags.DirtyCheck
     this.checkViewChanges()