-
-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: router stream injection #3216
Merged
Merged
Changes from 29 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
172ed40
fix: router stream injection
tannerlinsley 49b0716
Merge remote-tracking branch 'origin/main' into fix-router-stream-inj…
tannerlinsley 8d8ebf8
fix: use web streams instead
tannerlinsley 450043d
no log
tannerlinsley 78c4af9
fix: more explicit stream timings
tannerlinsley b4f0cd5
fix: router stream lifecycle
tannerlinsley 3c44011
fix: router stream lifecycel
tannerlinsley ec1eac7
checkpoint
tannerlinsley d9a5fac
checkpoint
schiller-manuel c97ca14
ci: apply automated fixes
autofix-ci[bot] a3e315a
so close!
tannerlinsley 779efb0
fixes
tannerlinsley ae21023
readable streams
tannerlinsley 75e94dd
inject promises
tannerlinsley 94a245d
almost there
tannerlinsley df99ace
please
tannerlinsley 96927c1
yEssssss
tannerlinsley a5e9861
YESSSSS
tannerlinsley 7bceb8a
almost there
tannerlinsley 95d1c6c
move scripts into head
schiller-manuel 8c9e856
fix lockfile
schiller-manuel a1b1956
override react version in monorepo
schiller-manuel 1163814
fix buffering
schiller-manuel 7075aab
matrix build for react
schiller-manuel ced2fd0
fix stream demo
tannerlinsley 1c80465
Revert "matrix build for react"
schiller-manuel abf9aae
Merge branch 'main' into fix-router-stream-injection
schiller-manuel a992b2c
updates
tannerlinsley 768b6c3
remove unnecessary TSR queue
tannerlinsley 8a541fe
bump nx
schiller-manuel 89de5c1
fix lint
schiller-manuel 91bf350
adding back ScriptOnce for clerk compat
schiller-manuel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can see, at this current time, this action of setting
serializer: SuperJSON
is not possible since theserializer
property (previously namedtransformer
) no longer exists onRouterOptions
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the whole non-start SSR story needs a major overhaul. let's do this separately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
Are we committing to removing user-configurable
transformer/serializer
though?If not, I think it'd make sense to introduce a bug where we leave the
RouterOptions
interface "as-is" but disable functionality in code. Then wire it back up in another PR with any renaming that needs to be done.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for now it cant be configured. but this functionality should be re-added at some point.