-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(react): update the react-native.md section #8506
Conversation
View your CI Pipeline Execution ↗ for commit 27d766e.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/isSubscribed #8506 +/- ##
=====================================================
Coverage 84.29% 84.29%
=====================================================
Files 26 26
Lines 363 363
Branches 103 102 -1
=====================================================
Hits 306 306
Misses 48 48
Partials 9 9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks. do you think this section is still needed ?
I don't think so, it becomes too complexe for a very marginal usecase. Let's remove it! |
@TkDodo I agree, the section can be removed. The new prop is enough. subscribed and enabled are technically still different, we should add some info around that topic |
thanks. I think I’ll ship the feature and we can iterate on the docs later too |
…the query cache with an option (#8348) * feat(react-query): allow useQuery and useQueries to unsubscribe from the query cache with an option * test: subscribed * fix: revert calling getOptimisticResult later * docs(react): update the react-native.md section (#8506) * update the doc * update the doc --------- Co-authored-by: Dominik Dorfmeister <[email protected]> * docs: reference --------- Co-authored-by: Florian De la comble <[email protected]>
No description provided.