chore: Use typescript-eslint v6 features (#594)

* chore: Use typescript-eslint v6 features * Remove unnecessary parserOptions * Delete stray prettierrc
TanStack · Feb 3, 2024 · e633c67 · e633c67
1 parent 70e4fdb
commit e633c67
Show file tree

Hide file tree

Showing 21 changed files with 163 additions and 118 deletions.
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -3,11 +3,14 @@
 /** @type {import('eslint').Linter.Config} */
 const config = {
   root: true,
+  reportUnusedDisableDirectives: true,
+  ignorePatterns: ['**/build', '**/coverage', '**/dist'],
   parser: '@typescript-eslint/parser',
   plugins: ['@typescript-eslint', 'import'],
   extends: [
-    'plugin:@typescript-eslint/eslint-recommended',
+    'eslint:recommended',
     'plugin:@typescript-eslint/recommended',
+    'plugin:@typescript-eslint/stylistic',
     'plugin:import/recommended',
     'plugin:import/typescript',
     'prettier',
@@ -18,7 +21,7 @@ const config = {
   },
   parserOptions: {
     tsconfigRootDir: __dirname,
-    project: './tsconfig.json',
+    project: true,
     sourceType: 'module',
     ecmaVersion: 2020,
   },
@@ -34,14 +37,17 @@ const config = {
     },
   },
   rules: {
+    '@typescript-eslint/array-type': 'off',
     '@typescript-eslint/ban-types': 'off',
     '@typescript-eslint/ban-ts-comment': 'off',
+    '@typescript-eslint/consistent-type-definitions': 'off',
     '@typescript-eslint/consistent-type-imports': 'error',
     '@typescript-eslint/explicit-module-boundary-types': 'off',
     '@typescript-eslint/no-empty-interface': 'off',
     '@typescript-eslint/no-explicit-any': 'off',
     '@typescript-eslint/no-non-null-assertion': 'off',
     '@typescript-eslint/no-unnecessary-condition': 'error',
+    '@typescript-eslint/no-unused-vars': 'off',
     '@typescript-eslint/no-inferrable-types': [
       'error',
       {
@@ -52,8 +58,10 @@ const config = {
     'import/no-cycle': 'error',
     'import/no-unresolved': ['error', { ignore: ['^@tanstack/'] }],
     'import/no-unused-modules': ['off', { unusedExports: true }],
+    'no-async-promise-executor': 'off',
+    'no-empty': 'off',
     'no-redeclare': 'off',
-    '@typescript-eslint/no-unused-vars': 'off',
+    'no-undef': 'off',
   },
   overrides: [
     {

diff --git a/examples/react/next-server-actions/.eslintrc.js b/examples/react/next-server-actions/.eslintrc.js
@@ -1,7 +1,3 @@
 module.exports = {
   extends: 'next/core-web-vitals',
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: ['./tsconfig.json'],
-  },
 }
diff --git a/examples/react/simple/.eslintrc.cjs b/examples/react/simple/.eslintrc.cjs
@@ -3,10 +3,6 @@
 /** @type {import('eslint').Linter.Config} */
 const config = {
   extends: ['plugin:react/recommended', 'plugin:react-hooks/recommended'],
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: './tsconfig.json',
-  },
   rules: {
     'react/no-children-prop': 'off',
   },

diff --git a/examples/react/ui-libraries/.eslintrc.cjs b/examples/react/ui-libraries/.eslintrc.cjs
@@ -2,14 +2,7 @@
 
 /** @type {import('eslint').Linter.Config} */
 const config = {
-  env: { browser: true, es2020: true },
-  extends: [
-    'eslint:recommended',
-    'plugin:@typescript-eslint/recommended',
-    'plugin:react-hooks/recommended',
-  ],
-  parser: '@typescript-eslint/parser',
-  parserOptions: { ecmaVersion: 'latest', sourceType: 'module' },
+  extends: ['plugin:react-hooks/recommended'],
   plugins: ['react-refresh'],
   rules: {
     'react-refresh/only-export-components': 'warn',

diff --git a/examples/react/valibot/.eslintrc.cjs b/examples/react/valibot/.eslintrc.cjs
@@ -3,10 +3,6 @@
 /** @type {import('eslint').Linter.Config} */
 const config = {
   extends: ['plugin:react/recommended', 'plugin:react-hooks/recommended'],
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: './tsconfig.json',
-  },
   rules: {
     'react/no-children-prop': 'off',
   },

diff --git a/examples/react/yup/.eslintrc.cjs b/examples/react/yup/.eslintrc.cjs
@@ -3,10 +3,6 @@
 /** @type {import('eslint').Linter.Config} */
 const config = {
   extends: ['plugin:react/recommended', 'plugin:react-hooks/recommended'],
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: './tsconfig.json',
-  },
   rules: {
     'react/no-children-prop': 'off',
   },

diff --git a/examples/react/zod/.eslintrc.cjs b/examples/react/zod/.eslintrc.cjs
@@ -3,10 +3,6 @@
 /** @type {import('eslint').Linter.Config} */
 const config = {
   extends: ['plugin:react/recommended', 'plugin:react-hooks/recommended'],
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: './tsconfig.json',
-  },
   rules: {
     'react/no-children-prop': 'off',
   },

diff --git a/examples/react/zod/.prettierrc b/examples/react/zod/.prettierrc
diff --git a/package.json b/package.json
@@ -43,8 +43,8 @@
     "@types/node": "^18.19.3",
     "@types/react": "^18.2.45",
     "@types/react-dom": "^18.0.5",
-    "@typescript-eslint/eslint-plugin": "^6.4.1",
-    "@typescript-eslint/parser": "^6.4.1",
+    "@typescript-eslint/eslint-plugin": "^6.20.0",
+    "@typescript-eslint/parser": "^6.20.0",
     "@vitest/coverage-istanbul": "^1.2.2",
     "eslint": "^8.56.0",
     "eslint-config-prettier": "^9.1.0",

diff --git a/packages/form-core/.eslintrc.cjs b/packages/form-core/.eslintrc.cjs
@@ -1,11 +1,6 @@
 // @ts-check
 
 /** @type {import('eslint').Linter.Config} */
-const config = {
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: './tsconfig.json',
-  },
-}
+const config = {}
 
 module.exports = config
diff --git a/packages/form-core/src/FieldApi.ts b/packages/form-core/src/FieldApi.ts
@@ -305,7 +305,6 @@ export class FieldApi<
     this.store = new Store<FieldState<TData>>(
       {
         value: this.getValue(),
-        // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
         meta: this._getMeta() ?? {
           isValidating: false,
           isTouched: false,
@@ -424,7 +423,6 @@ export class FieldApi<
     >,
   ) => {
     // Default Value
-    // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
     if (this.state.value === undefined) {
       const formDefault =
         opts.form.options.defaultValues?.[opts.name as keyof TParentData]

diff --git a/packages/form-core/src/FormApi.ts b/packages/form-core/src/FormApi.ts
@@ -314,9 +314,7 @@ export class FormApi<
           Object.assign(
             {},
             this.state as any,
-            // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
             shouldUpdateState ? options.defaultState : {},
-            // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
             shouldUpdateValues
               ? {
                   values: options.defaultValues,

diff --git a/packages/react-form/.eslintrc.cjs b/packages/react-form/.eslintrc.cjs
@@ -3,10 +3,6 @@
 /** @type {import('eslint').Linter.Config} */
 const config = {
   extends: ['plugin:react/recommended', 'plugin:react-hooks/recommended'],
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: './tsconfig.json',
-  },
   rules: {
     'react/jsx-key': ['error', { checkFragmentShorthand: true }],
     'react-hooks/exhaustive-deps': 'error',

diff --git a/packages/solid-form/.eslintrc.cjs b/packages/solid-form/.eslintrc.cjs
@@ -1,11 +1,6 @@
 // @ts-check
 
 /** @type {import('eslint').Linter.Config} */
-const config = {
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: './tsconfig.json',
-  },
-}
+const config = {}
 
 module.exports = config
diff --git a/packages/solid-form/src/createField.tsx b/packages/solid-form/src/createField.tsx
@@ -1,4 +1,4 @@
-import { FieldApi, type Validator } from '@tanstack/form-core'
+import { FieldApi } from '@tanstack/form-core'
 import {
   createComponent,
   createComputed,
@@ -9,7 +9,12 @@ import {
 } from 'solid-js'
 import { formContext, useFormContext } from './formContext'
 
-import type { DeepKeys, DeepValue, Narrow } from '@tanstack/form-core'
+import type {
+  DeepKeys,
+  DeepValue,
+  Narrow,
+  Validator,
+} from '@tanstack/form-core'
 import type { JSXElement } from 'solid-js'
 import type { CreateFieldOptions } from './types'
 

diff --git a/packages/valibot-form-adapter/.eslintrc.cjs b/packages/valibot-form-adapter/.eslintrc.cjs
@@ -1,11 +1,6 @@
 // @ts-check
 
 /** @type {import('eslint').Linter.Config} */
-const config = {
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: './tsconfig.json',
-  },
-}
+const config = {}
 
 module.exports = config
diff --git a/packages/vue-form/.eslintrc.cjs b/packages/vue-form/.eslintrc.cjs
@@ -1,11 +1,6 @@
 // @ts-check
 
 /** @type {import('eslint').Linter.Config} */
-const config = {
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: './tsconfig.json',
-  },
-}
+const config = {}
 
 module.exports = config
diff --git a/packages/vue-form/src/useField.tsx b/packages/vue-form/src/useField.tsx
@@ -1,9 +1,14 @@
-import { FieldApi, type Validator } from '@tanstack/form-core'
-import type { DeepKeys, DeepValue, Narrow } from '@tanstack/form-core'
+import { FieldApi } from '@tanstack/form-core'
 import { useStore } from '@tanstack/vue-store'
 import { defineComponent, onMounted, onUnmounted, watch } from 'vue'
-import type { SlotsType, SetupContext, Ref } from 'vue'
 import { provideFormContext, useFormContext } from './formContext'
+import type {
+  DeepKeys,
+  DeepValue,
+  Narrow,
+  Validator,
+} from '@tanstack/form-core'
+import type { SlotsType, SetupContext, Ref } from 'vue'
 import type { UseFieldOptions } from './types'
 
 declare module '@tanstack/form-core' {

diff --git a/packages/yup-form-adapter/.eslintrc.cjs b/packages/yup-form-adapter/.eslintrc.cjs
@@ -1,11 +1,6 @@
 // @ts-check
 
 /** @type {import('eslint').Linter.Config} */
-const config = {
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: './tsconfig.json',
-  },
-}
+const config = {}
 
 module.exports = config
diff --git a/packages/zod-form-adapter/.eslintrc.cjs b/packages/zod-form-adapter/.eslintrc.cjs
@@ -1,11 +1,6 @@
 // @ts-check
 
 /** @type {import('eslint').Linter.Config} */
-const config = {
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: './tsconfig.json',
-  },
-}
+const config = {}
 
 module.exports = config