Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run test:types on CI #9

Merged
merged 5 commits into from
Jan 3, 2024
Merged

ci: Run test:types on CI #9

merged 5 commits into from
Jan 3, 2024

Conversation

lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Dec 31, 2023

I've had to disable noImplicitAny, and add some @ts-expect-error comments, but these are isolated to bin/config.js, and seem to be because liftoff does not have types. These issues can sorted out in subsequent PRs.

@lachlancollins lachlancollins changed the title chore: Add test:types to CI ci: Run test:types on CI Jan 1, 2024
@lachlancollins lachlancollins merged commit 00dc983 into main Jan 3, 2024
1 check passed
@lachlancollins lachlancollins deleted the type-check branch January 3, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant