Refactor initialization, functions and classes #1388
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C0rn3j
force-pushed
the
800
branch
4 times, most recently
from
c543976 to
0c49c6e
Compare
Somewhat arrange to current upstream state Small Prefs fix up Bootstrap: Use dataclass t_main reworks Move classes on top of main More reworking GuiVar: Remove duplicated macOS detection More rework More rework, create class Formats, remove global formats Fix colon convention Remove empty rework file More refactoring Add more typing More rework Remove old comment Refactor Refactor fixups Moar refactor Refactor class Tauon Fix up asset_loader() Moar refactor More reworks Remove doubled ctypes import More refactor Further refactor and add accidentally deleted classes back Premove touchups Add Bag to Tauon and continue refactoring pctl reworks Move some things around and rename devance func to "previous" further reworks Further reworks Further reworks More refactoring, convert Prefs to a dataclass, to be merged with Bag Small refactor Small refactor + adapt some upstream changes fix lastfm url Start using classes for Radio playlists and stations (Taiko2k#1422) * Radio changes WIP * Fix ups to get it running * Add migrations * Convert more code * Fix broken buttons * Do not wipe website URL if stream URL hasn't changed * Handle radio websocket better * Fix indent * Add the default station fallback URL back * Fix up adding radio and m3u radio * Fix if * Fix comma Fix merge issues Start up more refactors Further reworks and global eliminations More reworks More reworks, just kill me already Theme refactor Shoot me noooow, this is a call for heeeelp MORE REWORKS Probably enough for today More input refactors Fix get_track_in_playlist() Stash some more reworks Further refactors Simplify Menu Moar Reeefactor More refactor
C0rn3j
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goals here are:
t_bootstrap.pyby turning its contents into a regular class object, currently it functions as a global object import of sortsmain()function int_main.pyto be able to pass it, to do so we'll have to get rid of doing everything in the top level of the moduleEarly WIP, launches but crashes easily, somewhat ugly at the moment.