Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notification): send notification to admin when job failed #3653

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zwpaper
Copy link
Member

@zwpaper zwpaper commented Jan 8, 2025

tested with mock error messages, generated by the background_job::start():

CleanShot 2025-01-08 at 17 50 23@2x

CleanShot 2025-01-08 at 17 50 42@2x

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.

Project coverage is 63.03%. Comparing base (02025aa) to head (eabcb1f).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
.../tabby-webserver/src/service/background_job/mod.rs 0.00% 35 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3653      +/-   ##
==========================================
- Coverage   63.06%   63.03%   -0.04%     
==========================================
  Files         204      204              
  Lines       23901    23923      +22     
==========================================
+ Hits        15074    15079       +5     
- Misses       8827     8844      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.create(
NotificationRecipient::Admin,
&format!(
r#"Background job failed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add link to /jobs/${id} page for the failed job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants