Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: [FEATURE] Allow null coalesce operator in evaluation (#522) #574

Closed
wants to merge 1 commit into from

Conversation

CDRO
Copy link

@CDRO CDRO commented Oct 28, 2021

This is a rewrite of my PR for v2, since simply "patching what changed" did obviously not work.

This is still work in progress, as I'm not sure how to properly write the tests and as it is not as straight forward to create your snippet testing as it was in v2 (or at least, I couldn't find out, how to get it to work properly), but I'll try to work on it based on other examples in the next weeks.

As for now, most tests work and are green, but basically, what does not work is testing this:

<span>{ model.field ?? model.fallback ?? 'Default' }</span>

Maybe this is not possible with fluid v3 anymore and it has to be written differently, I hope I'll find this out soon :-)

@lolli42
Copy link
Member

lolli42 commented May 12, 2022

Hey.
As outlined in #591, we'll close v3 related PR's for now. Your PR #572 is kept, and we'll see on how to continue on this one.

@lolli42 lolli42 closed this May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants