[TASK] Use constructor DI for viewhelper

TYPO3-Documentation · Jul 13, 2024 · 9ae202f · 9ae202f
1 parent 7a4dba9
commit 9ae202f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/Classes/ViewHelpers/GravatarViewHelper.php b/Classes/ViewHelpers/GravatarViewHelper.php
@@ -42,21 +42,16 @@ class GravatarViewHelper extends AbstractTagBasedViewHelper
      * @var string
      */
     protected $tagName = 'img';
-
-    protected UriFactory $uriFactory;
-
-    public function injectUriFactory(UriFactory $uriFactory): void
+    public function __construct(private readonly UriFactory $uriFactory)
     {
-        $this->uriFactory = $uriFactory;
+        parent::__construct();
     }
 
     /**
      * Initialize arguments
      */
     public function initializeArguments(): void
     {
-        parent::initializeArguments();
-
         $this->registerUniversalTagAttributes();
         $this->registerArgument('emailAddress', 'string', '', true)
              ->registerArgument('defaultImageUri', 'string', '', false)

diff --git a/Tests/Functional/ViewHelpers/GravatarViewHelperTest.php b/Tests/Functional/ViewHelpers/GravatarViewHelperTest.php
@@ -20,6 +20,7 @@
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\Test;
 use T3docs\BlogExample\ViewHelpers\GravatarViewHelper;
+use TYPO3\CMS\Core\Http\UriFactory;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Fluid\View\StandaloneView;
 use TYPO3\TestingFramework\Core\Functional\FunctionalTestCase;
@@ -36,7 +37,7 @@ protected function setUp(): void
     {
         parent::setUp();
 
-        $this->subject = new GravatarViewHelper();
+        $this->subject = new GravatarViewHelper(GeneralUtility::makeInstance(UriFactory::class));
     }
 
     public static function renderDataProvider(): array