-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Deprecation] renderStatic() for Fluid ViewHelpers #4735
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s2b
reviewed
Sep 10, 2024
linawolf
commented
Sep 10, 2024
linawolf
commented
Sep 10, 2024
froemken
reviewed
Sep 10, 2024
Documentation/ApiOverview/Fluid/_CustomViewHelper/_GravatarTagBasedViewHelper.php
Show resolved
Hide resolved
froemken
reviewed
Sep 10, 2024
...n/ApiOverview/Fluid/_CustomViewHelper/_GravatarTagBasedViewHelper_getContentArgumentName.php
Show resolved
Hide resolved
froemken
reviewed
Sep 10, 2024
...n/ApiOverview/Fluid/_CustomViewHelper/_GravatarTagBasedViewHelper_getContentArgumentName.php
Show resolved
Hide resolved
I get following error while rendering the docs:
|
linawolf
added a commit
to TYPO3-Documentation/blog_example
that referenced
this pull request
Sep 11, 2024
froemken
reviewed
Sep 11, 2024
Documentation/ApiOverview/Fluid/_CustomViewHelper/_GravatarTagBasedViewHelperInvocation.php
Outdated
Show resolved
Hide resolved
froemken
reviewed
Sep 11, 2024
...n/ApiOverview/Fluid/_CustomViewHelper/_GravatarTagBasedViewHelper_getContentArgumentName.php
Outdated
Show resolved
Hide resolved
froemken
reviewed
Sep 11, 2024
...n/ApiOverview/Fluid/_CustomViewHelper/_GravatarTagBasedViewHelper_getContentArgumentName.php
Outdated
Show resolved
Hide resolved
froemken
reviewed
Sep 11, 2024
Documentation/ApiOverview/Fluid/_CustomViewHelper/_MigrateRenderStaticInvocation.diff
Outdated
Show resolved
Hide resolved
froemken
reviewed
Sep 11, 2024
Documentation/ApiOverview/Fluid/_CustomViewHelper/_SomeTemplate.html
Outdated
Show resolved
Hide resolved
Co-authored-by: Stefan Frömken <[email protected]>
froemken
approved these changes
Sep 11, 2024
The backport to
stderr
stdout
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-12.4 12.4
# Navigate to the new working tree
cd .worktrees/backport-12.4
# Create a new branch
git switch --create backport-4735-to-12.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 1597e4adf58d47ac70e532da1925664e1f8ac9bf,59ff44d5f96541d939d6f3bd6d81f2e23a5a9087,15ffe6f3748c635103d2044e226dc84e7d462513,dfb17b8a0ba88675efaf3c942327479baf383a95,42250d86064cbeb547e568f38119d027453b4071,2ba842073a5b12992295815fe2dc04d52d146d66,e2a167c7a233e8780f7f0b60998b68ae4669a7e7,ff1c3195823e7bc4c856d21a35b51cf5630928d1,60c2f281a58cce23c589005f5b1e630da2915980
# Push it to GitHub
git push --set-upstream origin backport-4735-to-12.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-12.4 Then, create a pull request where the |
froemken
added a commit
that referenced
this pull request
Sep 11, 2024
* [Deprecation] renderStatic() for Fluid ViewHelpers References: TYPO3-Documentation/Changelog-To-Doc#1008 Releases: main, 12.4 * Update Documentation/ApiOverview/Fluid/DevelopCustomViewhelper.rst * Update Documentation/ApiOverview/Fluid/DevelopCustomViewhelper.rst * [TASK] Test VH input for null or non-string * [TASK] Test VH input for null or non-string * Apply suggestions from code review Co-authored-by: Stefan Frömken <[email protected]> --------- Co-authored-by: Stefan Frömken <[email protected]>
linawolf
added a commit
that referenced
this pull request
Sep 11, 2024
* [Deprecation] renderStatic() for Fluid ViewHelpers (#4735) * [Deprecation] renderStatic() for Fluid ViewHelpers References: TYPO3-Documentation/Changelog-To-Doc#1008 Releases: main, 12.4 * Update Documentation/ApiOverview/Fluid/DevelopCustomViewhelper.rst * Update Documentation/ApiOverview/Fluid/DevelopCustomViewhelper.rst * [TASK] Test VH input for null or non-string * [TASK] Test VH input for null or non-string * Apply suggestions from code review Co-authored-by: Stefan Frömken <[email protected]> --------- Co-authored-by: Stefan Frömken <[email protected]> * Apply suggestions from code review * Update Documentation/ApiOverview/Fluid/DevelopCustomViewhelper.rst * Update Documentation/ApiOverview/Fluid/DevelopCustomViewhelper.rst * Update Documentation/ApiOverview/Fluid/DevelopCustomViewhelper.rst * Update Documentation/ApiOverview/Fluid/DevelopCustomViewhelper.rst * Update Documentation/ApiOverview/Fluid/DevelopCustomViewhelper.rst * Update Documentation/ApiOverview/Fluid/DevelopCustomViewhelper.rst --------- Co-authored-by: Lina Wolf <[email protected]> Co-authored-by: Chris Müller <[email protected]>
linawolf
added a commit
to TYPO3-Documentation/blog_example
that referenced
this pull request
Sep 12, 2024
* [Deprecation] renderStatic() for Fluid ViewHelpers See also: TYPO3-Documentation/TYPO3CMS-Reference-CoreApi#4735 References: TYPO3-Documentation/Changelog-To-Doc#1008 * Update Classes/ViewHelpers/GravatarViewHelper.php Co-authored-by: Stefan Frömken <[email protected]> * Update Resources/Private/Templates/Post/Show.html --------- Co-authored-by: Stefan Frömken <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References: TYPO3-Documentation/Changelog-To-Doc#1008
Releases: main, 12.4
See also #4734