Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization: Russian and English #1761

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

Satton2
Copy link
Contributor

@Satton2 Satton2 commented Feb 4, 2025

  • Made the way "base roles" and "subroles" spelled consistent.
  • Added some minor changes to make text a bit more clearly understandable (including more consistent usage of "submenu" and "distribution" terms).
  • Other minor changes.
  • Localized new/updated text into Russian (for some reason it says in-game that it's 99.9% while I don't see anything left: bug/actually don't see a thing?)

- Made the way "base roles" and "subroles" spelled consistent.
- Added some minor changes to make text a bit more clearly understandable (including more consistent usage of "submenu" and "distribution" terms).
- Other minor changes.
- Localized new/updated text into Russian (for some reason it says in-game that it's 99.9% while I don't see anything left: bug/actually don't see a thing?)
Copy link
Member

@saibotk saibotk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thank you very much, as always 🫶

This might be a bug? Idk if so we can track that in a new issue.

@saibotk saibotk merged commit 6721295 into TTT-2:master Feb 4, 2025
4 checks passed
@TimGoll
Copy link
Member

TimGoll commented Feb 4, 2025

Localized new/updated text into Russian (for some reason it says in-game that it's 99.9% while I don't see anything left: bug/actually don't see a thing?)

this counter also includes installed addons. Might be that you have one addon that adds one localized line that is not translated into russian

@Satton2
Copy link
Contributor Author

Satton2 commented Feb 4, 2025

Localized new/updated text into Russian (for some reason it says in-game that it's 99.9% while I don't see anything left: bug/actually don't see a thing?)

this counter also includes installed addons. Might be that you have one addon that adds one localized line that is not translated into russian

No, sadly. There was only one subrole (to test that inspection stuff) and admin mod. They both were deleted/disabled when I found that percentage issue. I will test a bit more latter and maybe will create an Issue.

@Satton2 Satton2 deleted the localization-1 branch February 4, 2025 16:14
@TimGoll
Copy link
Member

TimGoll commented Feb 4, 2025

you could print the sizes of both english and russian language table and then print the identifier that is missing from the russian language file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants