Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch back to w2dynamics upstream repository #5

Closed
wants to merge 5 commits into from
Closed

Switch back to w2dynamics upstream repository #5

wants to merge 5 commits into from

Conversation

hmenke
Copy link
Member

@hmenke hmenke commented Nov 17, 2023

We have to pin Python to 3.11 in CI, because w2dynamics depends on distutils which was removed in Python 3.12.

Removing distutils from w2dynamics would be a larger undertaking since it would require reworking the entire f2py integration.

hmenke
hmenke commented Nov 17, 2023
View reviewed changes
.github/workflows/build.yml
if: ${{ contains(matrix.cxx, 'clang') }}
run:
echo "CXXFLAGS=-stdlib=libc++" >> $GITHUB_ENV

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block was duplicated.

@Wentzell Wentzell requested a review from the-hampel November 21, 2023 16:27
the-hampel
the-hampel approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@the-hampel the-hampel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hmenke for the fixes. I agree we should limit the w2dyn interface for now to Python 3.11 maximum until w2dynamics/w2dynamics#25 is merged into w2dynamics. Then we should remove the constrain again.

@the-hampel
Copy link
Member

@hmenke @HugoStrand @Wentzell ,
for python version <3.12 this works now just fine, i.e. using the master branch of w2dynamics. However, for py ver 3.12 support they would need to merge w2dynamics/w2dynamics#25 . I would vote for merging this now. If w2dynamics merges the PR there are no further changes necessary here to enable py 3.12 support.

@the-hampel the-hampel mentioned this pull request Feb 23, 2024
Merged
@Wentzell Wentzell force-pushed the unstable branch 3 times, most recently from cb11c2d to 1063144 Compare March 25, 2024 22:25
@Wentzell
Copy link
Member

I have updated w2dynamics to the very latest commit w2dynamics/w2dynamics@7364c00 on unstable

I have also changed the cmake logic to now use FetchContent instead of ExternalProject

@Wentzell Wentzell closed this Mar 25, 2024
@Wentzell
Copy link
Member

CI is passing also without fixing the Python Version in ghactions.
C.f. https://github.com/TRIQS/w2dynamics_interface/actions/runs/8427811994

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-hampel the-hampel the-hampel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hmenke @the-hampel @Wentzell