-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tdp browse
operation
#636
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulFarault
force-pushed
the
paul/fix-inexisting-browse-operation
branch
from
December 3, 2024 16:43
7323656
to
65532d4
Compare
Force pushed to resolve failing pipeline (wrong commit message). |
SteBaum
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and tested.
rpignolet
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes
Fixes #483
Additional comments
It is now possible to retrieve an operation from it's order (using the new
tdp browse <deployment_id> <operation_order>
command).When an operation is retrieved by its name (using the existing
tdp browse <deployment_id> <operation_name>
command), if multiple operations match the search, the output now list all operations and ask the user to retrieve a specific one using its order (instead of displaying all of their logs).This PR also provide more explicit messages for the
tdp browse
command. I also took the opportunity to simplify thetdp browse
logic and to remove bothprint_table
andprint_object
utils functions.Agreements