Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tdp browse operation #636

Merged
merged 9 commits into from
Dec 16, 2024
Merged

Conversation

PaulFarault
Copy link
Contributor

Which issue(s) this PR fixes

Fixes #483

Additional comments

It is now possible to retrieve an operation from it's order (using the new tdp browse <deployment_id> <operation_order> command).

When an operation is retrieved by its name (using the existing tdp browse <deployment_id> <operation_name> command), if multiple operations match the search, the output now list all operations and ask the user to retrieve a specific one using its order (instead of displaying all of their logs).

This PR also provide more explicit messages for the tdp browse command. I also took the opportunity to simplify the tdp browse logic and to remove both print_table and print_object utils functions.

Agreements

@PaulFarault PaulFarault self-assigned this Dec 3, 2024
@PaulFarault PaulFarault force-pushed the paul/fix-inexisting-browse-operation branch from 7323656 to 65532d4 Compare December 3, 2024 16:43
@PaulFarault
Copy link
Contributor Author

Force pushed to resolve failing pipeline (wrong commit message).

Copy link
Contributor

@SteBaum SteBaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested.

@PaulFarault PaulFarault merged commit 5950e6a into master Dec 16, 2024
5 checks passed
@PaulFarault PaulFarault deleted the paul/fix-inexisting-browse-operation branch December 16, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tdp browse prints wrong info with wrong parameters
3 participants