check if missing hosts during the deployment

[SteBaum]

Which issue(s) this PR fixes

Fixes # None

Additional comments

When a deployment is launched check if hosts have been removed from the inventory.ini. The logger displays a warning if a host has been removed.

There are three commits:

• Added get_collections_hosts method for the Collections class.
• Added check_collections_hosts method for the Collection class. It compares hosts from the collections with the hosts in the inventory.ini file and logger sends a warning if a host is missing in the inventory.ini file.
• Integrated check_collections_hosts in the deployment iterator.

Agreements

• I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004.
• I hereby agree to grant TOSIT a copyright license to use my contributions.

[SteBaum]

The host checking procedure slows down the deployment. It can specifically be seen when a tdp deploy --dry or tdp -deploy --mock-deploy is performed.

[PaulFarault]

I see several issues here.

1. get_collections_hosts should be a property initialized directly within the class, rather than a getter that computes it each time it's called. Additionally, its implementation can be made much more efficient by creating a set directly, avoiding the need for three loops.
2. check_collections_hosts is currently returning the first host removed from the collections compared to the inventory:

• This behavior is unrelated to the operations running in the current deployment.
• Since it always returns the same value, there’s no need to invoke it for every operation.

It could be useful to both store the hosts used in the collections and verify that the hosts for the current operation haven't been removed from inventory.ini. However, the current approach doesn't seem like the right solution for this.

[SteBaum]

No more up to date.