ServiceVariables: do not store service schema
#527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulFarault
force-pushed
the
service-variables-schema
branch
from
0d9ea44 to
9c58e83
Compare
SteBaum
approved these changes
Nov 27, 2023
rpignolet
reviewed
Nov 29, 2023
| @@ -242,7 +236,7 @@ def validate_schema(self, variables: Variables, schema: dict) -> None: | |||
| except exceptions.ValidationError as e: | |||
| raise InvalidSchema("Schema is invalid", variables.name) from e | |||
|
|
|||
| def validate(self) -> None: | |||
| def validate(self, schema: dict) -> None: | |||
There was a problem hiding this comment.
I don't understand this PR. Now when I have an instance of ServiceVariables I need to give a dict representing the schema every time I want to validate the variables? But the schema doesn't change between each validation.
There was a problem hiding this comment.
With #320 in mind (preventing default variables copy), we'll need to have access to default variables in the validate method. Both default variables and schema come from the Collections object, hence, it'll feel better for me to pass a collections object as an argument instead of storing everything in the ServiceVariables object (as it is only required for schema validation).
I did this PR to prepare this change.
PaulFarault
force-pushed
the
service-variables-schema
branch
from
9c58e83 to
d426409
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes
Fixes None
There is no need to store the schema in the
ServiceVariablesclass. It can be retrieve from the collections object and passed as an argument when needed.Agreements