Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check operation availability on host before execution #491

Conversation

PaulFarault
Copy link
Contributor

@PaulFarault PaulFarault commented Oct 30, 2023

Which issue(s) this PR fixes

Fixes #490

Additional comments

If a host is provided for an operation, check if the operation is available for this host before executing it.
Log a custom error message in the database.

This is required to avoid edge case with the --limit <host> option on the ansible-playbook command.

Agreements

If a host is provided for an operation, check if the operation is
available for this host before executing it.
Log a custom error message in the database.

This is required to avoid edge case with the `--limit <host>` option
on the `ansible-playbook` command.
@PaulFarault PaulFarault self-assigned this Oct 30, 2023
@PaulFarault PaulFarault linked an issue Oct 30, 2023 that may be closed by this pull request
@PaulFarault PaulFarault changed the title fix: check operation availability on host before execution Check operation availability on host before execution Oct 30, 2023
@sergkudinov
Copy link
Contributor

Would be good to add a unit test for this case.

@sergkudinov
Copy link
Contributor

How to reproduce/to test manually?

@PaulFarault
Copy link
Contributor Author

How to reproduce/to test manually?

Try to run an operation on an host that is not defined for this operation.

@PaulFarault PaulFarault merged commit f8dacce into master Oct 31, 2023
@PaulFarault PaulFarault deleted the 490-check-that-operation-is-available-for-an-host-before-execution branch October 31, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check that operation is available for an host before execution
3 participants