-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue 346 transformed playbook.py into script instead of TDP cli #481
Conversation
27c9165
to
494e8b9
Compare
ac027a7
to
daaac6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4adc4c5
to
8ad5510
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could leverage click's features to parse options (and use the ones defined for the cli). This doesn't mean that the command will is part of the CLI.
8ad5510
to
05075e5
Compare
The review has been taken into account, did a force push to have clean commits of just the necessary changes.
de6303c
to
6c2a7cd
Compare
6c2a7cd
to
751d92e
Compare
I have changed the PR. It now does what is described in the description above and does not change failure if the meta outputdirectory already exists. |
review has been fixed with a force push to hvae clean commits
Which issue(s) this PR fixes
Fixes #346
Additional comments
import_playbook
toansible.builtin.import_playbook
for output yml files.Agreements