Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 346 transformed playbook.py into script instead of TDP cli #481

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

SteBaum
Copy link
Contributor

@SteBaum SteBaum commented Oct 26, 2023

Which issue(s) this PR fixes

Fixes #346

Additional comments

  • Removed the playbook command in main.py.
  • Transformed playbook.py into a script a developer can use outside of tdp lib commands.
  • Changed import_playbook to ansible.builtin.import_playbook for output yml files.

Agreements

@SteBaum SteBaum marked this pull request as draft October 26, 2023 08:45
@SteBaum SteBaum requested a review from PaulFarault October 26, 2023 09:39
@SteBaum SteBaum force-pushed the 346-playbook-script branch 2 times, most recently from 27c9165 to 494e8b9 Compare October 30, 2023 16:35
@SteBaum SteBaum self-assigned this Oct 30, 2023
@SteBaum SteBaum marked this pull request as ready for review October 30, 2023 16:42
scripts/playbooks.py Outdated Show resolved Hide resolved
scripts/playbooks.py Outdated Show resolved Hide resolved
scripts/playbooks.py Show resolved Hide resolved
@SteBaum SteBaum force-pushed the 346-playbook-script branch 2 times, most recently from ac027a7 to daaac6a Compare November 2, 2023 14:04
Copy link
Contributor

@PaulFarault PaulFarault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however you should wait for #496 and #479 to be merged before yours so that you'll be able to use the new types/classes with this PR. It would be easier in that way

@SteBaum SteBaum force-pushed the 346-playbook-script branch from 4adc4c5 to 8ad5510 Compare November 20, 2023 08:33
Copy link
Contributor

@PaulFarault PaulFarault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could leverage click's features to parse options (and use the ones defined for the cli). This doesn't mean that the command will is part of the CLI.

@SteBaum SteBaum force-pushed the 346-playbook-script branch from 8ad5510 to 05075e5 Compare November 28, 2023 15:05
@SteBaum SteBaum dismissed PaulFarault’s stale review November 28, 2023 15:13

The review has been taken into account, did a force push to have clean commits of just the necessary changes.

scripts/playbooks.py Outdated Show resolved Hide resolved
@SteBaum SteBaum force-pushed the 346-playbook-script branch from de6303c to 6c2a7cd Compare December 6, 2023 18:32
@SteBaum SteBaum force-pushed the 346-playbook-script branch from 6c2a7cd to 751d92e Compare December 6, 2023 18:39
@SteBaum
Copy link
Contributor Author

SteBaum commented Dec 8, 2023

I have changed the PR. It now does what is described in the description above and does not change failure if the meta outputdirectory already exists.

@SteBaum SteBaum dismissed PaulFarault’s stale review December 13, 2023 14:39

review has been fixed with a force push to hvae clean commits

@SteBaum SteBaum merged commit 95a896f into master Jan 12, 2024
5 checks passed
@SteBaum SteBaum deleted the 346-playbook-script branch January 12, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cli] Move the playbooks command to a script
3 participants