Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alow to override stale status #461

Merged
merged 5 commits into from
Oct 25, 2023
Merged

Alow to override stale status #461

merged 5 commits into from
Oct 25, 2023

Conversation

PaulFarault
Copy link
Contributor

@PaulFarault PaulFarault commented Oct 11, 2023 •
edited
Loading

Which issue(s) this PR fixes

Fixes #348
Fixes #465
Fixes #470

Additional comments

Allow to manually edit to_config and to_restart status properties.

Agreements

@PaulFarault PaulFarault self-assigned this Oct 11, 2023
This was referenced Oct 11, 2023
Closed
Closed
@PaulFarault
Copy link
Contributor Author

Force pushed after rebasing on master.

rpignolet
rpignolet reviewed Oct 19, 2023
View reviewed changes
tdp/cli/commands/status/generate_stales.py Show resolved Hide resolved
tdp/cli/utils.py Outdated Show resolved Hide resolved
@PaulFarault PaulFarault requested a review from rpignolet October 23, 2023 11:23
mdrutel
mdrutel approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@mdrutel mdrutel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested OK.
Maybe we could display messages written by the user with the option -m

tdp/cli/commands/status.py Outdated Show resolved Hide resolved
@PaulFarault
Copy link
Contributor Author

Maybe we could display messages written by the user with the option -m

I think that we should display both:

  • The last edition date in the status table
  • The history of editions, using a --history option

@PaulFarault PaulFarault merged commit 19403e9 into master Oct 25, 2023
5 checks passed
@PaulFarault PaulFarault deleted the add-detail-column branch October 25, 2023 08:12
@PaulFarault PaulFarault mentioned this pull request Oct 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdrutel mdrutel mdrutel approved these changes

@rpignolet rpignolet rpignolet approved these changes

Assignees

@PaulFarault PaulFarault

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@PaulFarault @rpignolet @mdrutel