Skip to content

Commit

Permalink
fix: remove noop playbook check
Browse files Browse the repository at this point in the history
  • Loading branch information
PaulFarault committed Oct 23, 2024
1 parent 220ae91 commit ca72fca
Showing 1 changed file with 0 additions and 12 deletions.
12 changes: 0 additions & 12 deletions tdp/core/dag.py
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,6 @@ def validate_dag_nodes(nodes: Operations, collections: Collections) -> None:
- \*_start operations can only be required from within its own service
- \*_install operations should only depend on other \*_install operations
- Each service (HDFS, HBase, Hive, etc) should have \*_install, \*_config, \*_init and \*_start operations even if they are "empty" (tagged with noop)
- Operations tagged with the noop flag should not have a playbook defined in the collection
- Each service action (config, start, init) except the first (install) must have an explicit dependency with the previous service operation within the same service
"""
# key: service_name
Expand Down Expand Up @@ -328,17 +327,6 @@ def warning(collection_name: str, message: str) -> None:
f"'{operation.service_name}_{previous_action}'"
)

# Operations tagged with the noop flag should not have a playbook defined in the collection

if operation_name in collections[operation.collection_name].playbooks:
if operation.noop:
c_warning(
f"Operation '{operation_name}' is noop and the playbook should not exist"
)
else:
if not operation.noop:
c_warning(f"Operation '{operation_name}' should have a playbook")

# Each service (HDFS, HBase, Hive, etc) should have *_install, *_config, *_init and *_start actions
# even if they are "empty" (tagged with noop)
# Part 2
Expand Down

0 comments on commit ca72fca

Please sign in to comment.