Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: timestamp formatting in logs from 12h to 24h #817

Merged
merged 1 commit into from
Nov 10, 2023
Merged

fix: timestamp formatting in logs from 12h to 24h #817

merged 1 commit into from
Nov 10, 2023

Conversation

giem-git
Copy link
Contributor

@giem-git giem-git commented Nov 8, 2023

Comments

Timestamp for hours was coded 'hh' which is hours in am/pm format (0-12)
Loki needs hours from 0 to 23

Agreements

@rpignolet rpignolet merged commit 644f002 into master Nov 10, 2023
@rpignolet rpignolet deleted the fix-timestamp-formatting-to-24h branch November 10, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehdibn mehdibn mehdibn approved these changes

@rpignolet rpignolet rpignolet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giem-git @rpignolet @mehdibn