Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: animation when you buy rakki tickets #1489

Merged
merged 5 commits into from
Jan 15, 2025

Conversation

clegirar
Copy link
Collaborator

@clegirar clegirar commented Jan 9, 2025

There is a preview here !

In the code we have 3 animations of confettis, because it's a ScrollView and the height is higher than a screen, so i put 3 animations in the entire ScrollView to see the animation wherever you are in the View.

@clegirar clegirar self-assigned this Jan 9, 2025
Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for teritori-dapp ready!

Name Link
🔨 Latest commit 1d6ed94
🔍 Latest deploy log https://app.netlify.com/sites/teritori-dapp/deploys/678627c455d49f0008fb65a0
😎 Deploy Preview https://deploy-preview-1489--teritori-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for gno-dapp ready!

Name Link
🔨 Latest commit 1d6ed94
🔍 Latest deploy log https://app.netlify.com/sites/gno-dapp/deploys/678627c463cdd20008b3e615
😎 Deploy Preview https://deploy-preview-1489--gno-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zxxma zxxma requested review from n0izn0iz and WaDadidou and removed request for n0izn0iz January 13, 2025 13:27
@WaDadidou
Copy link
Collaborator

The zoom level chanages the position of the animation. And it adds an extra vertical space at the bottom
image

What do you think about this adjustment ? WaDadidou@91e7d9e#diff-8e2c5b8031f032da60995a2ec1bed47f31b3db49f0ce3de39821c1d7f26382cfR103

  • Only 2 LottieAnimation
  • Centered regardless of the zoom level

image

@clegirar
Copy link
Collaborator Author

I think it could be cool to note somewhere all tests that we have to do in a PR (front-end), because it's the first time i hear about checking zoom level.

But you are right actually. I still think 2 animations is not enough but thanks for the proposition really, i think i'll keep 3 animations based on your proposal 👍

@clegirar
Copy link
Collaborator Author

clegirar commented Jan 14, 2025

Screenshot 2025-01-14 at 09 59 12

Got something like this, how do you find it @WaDadidou ?

And i think i found a better calcul without get screenContainerContentHeight.
Don't hesitate to give your opinion 👍

Copy link
Collaborator

@WaDadidou WaDadidou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes yes, nice choice :) LGTM

Copy link
Collaborator

@hthieu1110 hthieu1110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MikaelVallenet MikaelVallenet added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit 1909854 Jan 15, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants