-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: animation when you buy rakki tickets #1489
Conversation
Signed-off-by: clegirar <[email protected]>
Signed-off-by: clegirar <[email protected]>
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for gno-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: clegirar <[email protected]>
The zoom level chanages the position of the animation. And it adds an extra vertical space at the bottom What do you think about this adjustment ? WaDadidou@91e7d9e#diff-8e2c5b8031f032da60995a2ec1bed47f31b3db49f0ce3de39821c1d7f26382cfR103
|
I think it could be cool to note somewhere all tests that we have to do in a PR (front-end), because it's the first time i hear about checking zoom level. But you are right actually. I still think 2 animations is not enough but thanks for the proposition really, i think i'll keep 3 animations based on your proposal 👍 |
Signed-off-by: clegirar <[email protected]>
Got something like this, how do you find it @WaDadidou ? And i think i found a better calcul without get |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes yes, nice choice :) LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There is a preview here !
In the code we have 3 animations of confettis, because it's a
ScrollView
and the height is higher than a screen, so i put 3 animations in the entireScrollView
to see the animation wherever you are in the View.